-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
558677 export users wizard #145
Conversation
- update YARS API javadoc Signed-off-by: elena.parovyshnaya <[email protected]>
- equip CusomerBase with one more thematic query - fix CSV:Excel format: semicolon must be used instead of comma to be correctly shown in Excel products - correct tests expected output Signed-off-by: elena.parovyshnaya <[email protected]>
- new plug-in `loc.report.ui` is added to develop reporting ui components - User Export Dialog is designed and implemented - the dialog is bound to the supplied ui handler to be acessible via the Operator ui Signed-off-by: elena.parovyshnaya <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes required to fix the build
...oc.report.ui/src/org/eclipse/passage/loc/report/internal/ui/jface/ExportCustomersWizard.java
Show resolved
Hide resolved
...se.passage.loc.report.ui/src/org/eclipse/passage/loc/report/internal/ui/jface/ScopePage.java
Outdated
Show resolved
Hide resolved
...se.passage.loc.report.ui/src/org/eclipse/passage/loc/report/internal/ui/jface/ScopePage.java
Outdated
Show resolved
Hide resolved
...se.passage.loc.report.ui/src/org/eclipse/passage/loc/report/internal/ui/jface/ScopePage.java
Outdated
Show resolved
Hide resolved
...e.passage.loc.report.ui/src/org/eclipse/passage/loc/report/internal/ui/jface/TargetPage.java
Outdated
Show resolved
Hide resolved
...e.passage.loc.report.ui/src/org/eclipse/passage/loc/report/internal/ui/jface/TargetPage.java
Outdated
Show resolved
Hide resolved
- `loc.report.ui`: org.eclipse.osgi dependency lost precise version (3.15.200) as it looks like we use different target platform on CI - ui listeners and providers are reimplemented on function-base - `loc.report.core` and `loc.report.ui` plug-ins are included into `dashboard` feature Signed-off-by: elena.parovyshnaya <[email protected]>
- `loc.report.ui`: org.eclipse.jface dependency lost precise version (3.19.0) as it looks like we use different target platform on CI Signed-off-by: elena.parovyshnaya <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #145 +/- ##
===========================================
- Coverage 9.42% 9.40% -0.03%
- Complexity 103 105 +2
===========================================
Files 429 442 +13
Lines 12955 13212 +257
Branches 1111 1119 +8
===========================================
+ Hits 1221 1242 +21
- Misses 11698 11934 +236
Partials 36 36
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Elena!
Closes 558677 |
loc.report.ui, loc.users.ui
loc.report.ui
is added to develop reporting ui componentsExportCustomersWizard
is designed and implemented to guide an operator through export settingsExportCustomersHandler
to be acessible viathe Operator ui
loc.report.core
CustomerStorage
service is equipped with one more thematic queryyars api