Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

558677 export users wizard #145

Merged
merged 5 commits into from
Feb 24, 2020
Merged

558677 export users wizard #145

merged 5 commits into from
Feb 24, 2020

Conversation

eparovyshnaya
Copy link
Contributor

loc.report.ui, loc.users.ui

  • new plug-in loc.report.ui is added to develop reporting ui components
  • ExportCustomersWizard is designed and implemented to guide an operator through export settings
  • the dialog is bound to the supplied ui handler ExportCustomersHandler to be acessible via
    the Operator ui

loc.report.core

  • core CustomerStorage service is equipped with one more thematic query
  • CSV:Excel export format is fixed: semicolon is used instead of comma to be correctly shown in Excel product
  • tests are corrected according to the separator change

yars api

  • YARS API javadoc is fixed and updated

 - update YARS API javadoc

Signed-off-by: elena.parovyshnaya <[email protected]>
 - equip CusomerBase with one more thematic query
 - fix CSV:Excel format: semicolon must be used instead of comma to be
correctly shown in Excel products
 - correct tests expected output

Signed-off-by: elena.parovyshnaya <[email protected]>
 - new plug-in `loc.report.ui` is added to develop reporting ui
components
 - User Export Dialog is designed and implemented
 - the dialog is bound to the supplied ui handler to be acessible via
the Operator ui

Signed-off-by: elena.parovyshnaya <[email protected]>
Copy link
Contributor

@ruspl-afed ruspl-afed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes required to fix the build

 - `loc.report.ui`: org.eclipse.osgi dependency lost precise version
(3.15.200) as it looks like we use different target platform on CI
 - ui listeners and providers are reimplemented on function-base
 - `loc.report.core` and `loc.report.ui` plug-ins are included into
`dashboard` feature

Signed-off-by: elena.parovyshnaya <[email protected]>
 - `loc.report.ui`: org.eclipse.jface dependency lost precise version
(3.19.0) as it looks like we use different target platform on CI

Signed-off-by: elena.parovyshnaya <[email protected]>
@codecov
Copy link

codecov bot commented Feb 24, 2020

Codecov Report

Merging #145 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #145      +/-   ##
===========================================
- Coverage      9.42%   9.40%   -0.03%     
- Complexity      103     105       +2     
===========================================
  Files           429     442      +13     
  Lines         12955   13212     +257     
  Branches       1111    1119       +8     
===========================================
+ Hits           1221    1242      +21     
- Misses        11698   11934     +236     
  Partials         36      36              
Impacted Files Coverage Δ Complexity Δ
...org/eclipse/passage/loc/workbench/LocWokbench.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%) ⬆️
.../eclipse/passage/loc/jface/dialogs/Appearance.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%) ⬆️
...ssage/lic/jface/dialogs/LicensingStatusDialog.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%) ⬆️
...ge/loc/internal/licenses/ui/SelectLicensePlan.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%) ⬆️
...loc/internal/workbench/i18n/WorkbenchMessages.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%) ⬆️
.../dashboard/ui/wizards/IssueLicenseRequestPage.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%) ⬆️
.../tests/requirements/LicensingRequirementsTest.java 100.00% <0.00%> (ø) 7.00% <0.00%> (+2.00%) ⬇️
...equinox/requirements/BundleCapabilityResolver.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%) ⬆️
...x/requirements/ComponentConfigurationResolver.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%) ⬆️
...e/loc/internal/workbench/CreateDomainResource.java
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d4c3ea...de2dee0. Read the comment docs.

Copy link
Contributor

@ruspl-afed ruspl-afed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Elena!

@eparovyshnaya eparovyshnaya merged commit dd982fc into eclipse-passage:master Feb 24, 2020
@eparovyshnaya
Copy link
Contributor Author

Closes 558677

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants