Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1340] floating license pack issuing does not work for template #1341

Merged
merged 2 commits into from
Apr 5, 2024

Conversation

eparovyshnaya
Copy link
Contributor

fix 'equals' error on finding Feature Grant prototype

Closes #1340

@eparovyshnaya eparovyshnaya requested a review from ruspl-afed April 5, 2024 05:54
@eparovyshnaya eparovyshnaya added this to the 3.0.0 milestone Apr 5, 2024
fix 'equals' error on finding Feature Grant prototype
Copy link
Contributor

@ruspl-afed ruspl-afed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 33.71%. Comparing base (379fa28) to head (86b7b91).

Files Patch % Lines
.../licenses/core/FloatingLicensePackFromRequest.java 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1341   +/-   ##
=========================================
  Coverage     33.70%   33.71%           
  Complexity      394      394           
=========================================
  Files          1190     1190           
  Lines         25996    25996           
  Branches       1595     1595           
=========================================
+ Hits           8763     8764    +1     
+ Misses        16708    16707    -1     
  Partials        525      525           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eparovyshnaya eparovyshnaya merged commit 2354e18 into master Apr 5, 2024
5 of 6 checks passed
@ruspl-afed ruspl-afed deleted the 1340 branch April 30, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Operator: floating license pack issuing does not work for template
2 participants