Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 548112 - [Passage] create license plan from issue license wizard #134

Merged
merged 2 commits into from
Feb 15, 2020

Conversation

ruspl-afed
Copy link
Contributor

Change ZeroOneMany to accept Supplier
Add Appearance infra
Add SelectFromDialog infra
Remove unused code
Bump API version

Signed-off-by: Alexander Fedorov [email protected]

Change ZeroOneMany to accept Supplier
Add Appearance infra
Add SelectFromDialog infra
Remove unused code
Bump API version

Signed-off-by: Alexander Fedorov <[email protected]>
@codecov
Copy link

codecov bot commented Feb 15, 2020

Codecov Report

Merging #134 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #134      +/-   ##
===========================================
- Coverage      9.57%   9.55%   -0.03%     
  Complexity      103     103              
===========================================
  Files           419     421       +2     
  Lines         12749   12777      +28     
  Branches       1103    1103              
===========================================
  Hits           1221    1221              
- Misses        11492   11520      +28     
  Partials         36      36
Impacted Files Coverage Δ Complexity Δ
...loc/internal/workbench/i18n/WorkbenchMessages.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...org/eclipse/passage/loc/workbench/LocWokbench.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...clipse/passage/loc/workbench/SelectFromDialog.java 0% <0%> (ø) 0 <0> (?)
.../eclipse/passage/loc/jface/dialogs/Appearance.java 0% <0%> (ø) 0 <0> (?)
.../eclipse/passage/loc/internal/api/ZeroOneMany.java 0% <0%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ad3c40...82fe05b. Read the comment docs.

Copy link
Contributor

@eparovyshnaya eparovyshnaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really nice, but let's discuss some two points.

Change ZeroOneMany to accept Supplier
Add Appearance infra
Add SelectFromDialog infra
Remove unused code
Bump API version

Signed-off-by: Alexander Fedorov <[email protected]>
@eparovyshnaya eparovyshnaya merged commit ddbe042 into master Feb 15, 2020
@eparovyshnaya eparovyshnaya deleted the 548112/select_from_dialog branch February 21, 2020 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants