Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1289] Revisit API of "org.eclipse.passage.lic.hc" bundle #1339

Merged
merged 2 commits into from
Apr 5, 2024

Conversation

eparovyshnaya
Copy link
Contributor

@eparovyshnaya eparovyshnaya commented Apr 5, 2024

  • impl* packages gone to provisional API
  • two classes from public package gone to internal package provisional API

Closes #1289

@eparovyshnaya eparovyshnaya requested a review from ruspl-afed April 5, 2024 05:24
Copy link
Contributor

@ruspl-afed ruspl-afed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 33.71%. Comparing base (7b5b7dd) to head (03c891b).

Files Patch % Lines
...pse/passage/lic/internal/hc/i18n/MineMessages.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1339   +/-   ##
=========================================
  Coverage     33.71%   33.71%           
  Complexity      394      394           
=========================================
  Files          1190     1190           
  Lines         25996    25996           
  Branches       1595     1595           
=========================================
+ Hits           8764     8765    +1     
+ Misses        16708    16707    -1     
  Partials        524      524           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eparovyshnaya eparovyshnaya merged commit 379fa28 into master Apr 5, 2024
5 of 6 checks passed
@ruspl-afed ruspl-afed deleted the 1289 branch April 30, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revisit API of "org.eclipse.passage.lic.hc" bundle
2 participants