Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 560090 - [Passage] create billing feature #132

Merged
merged 2 commits into from
Feb 13, 2020
Merged

Bug 560090 - [Passage] create billing feature #132

merged 2 commits into from
Feb 13, 2020

Conversation

zelenyhleb
Copy link
Contributor

created feature, added copyrights and properties

Signed-off-by: Nikifor Fedorov [email protected]

created feature, added copyrights and properties

Signed-off-by: Nikifor Fedorov <[email protected]>
Copy link
Contributor

@ruspl-afed ruspl-afed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feature manifests look good, but we need to include it to the build, p2 update site and to the operator product to make use of it.

@codecov
Copy link

codecov bot commented Feb 13, 2020

Codecov Report

Merging #132 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #132   +/-   ##
========================================
  Coverage      9.58%   9.58%           
  Complexity      103     103           
========================================
  Files           418     418           
  Lines         12744   12744           
  Branches       1103    1103           
========================================
  Hits           1221    1221           
  Misses        11487   11487           
  Partials         36      36           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cce329...b56e160. Read the comment docs.

feature added to aggregator and operator is now including it

Signed-off-by: Nikifor Fedorov <[email protected]>
Copy link
Contributor

@ruspl-afed ruspl-afed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting for the build results to merge.

@eparovyshnaya eparovyshnaya merged commit c31c07a into eclipse-passage:master Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants