Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1191] "Import Licenses" wizard should support import from archive #1285

Merged
merged 5 commits into from
Feb 19, 2024

Conversation

eparovyshnaya
Copy link
Contributor

@eparovyshnaya eparovyshnaya commented Feb 18, 2024

ImportLicenseDialog is extended with proper hooks, as well as all the chain of inclusions that make your custom dialog work.

  • construct you verion of ImportLicenseDialog with custom LicenseFilesControl implementation (read license files from archive, for instance).
  • supply it to LicenseStatusDialog by defining your own version of BaseLicenseStatusDialog
  • supply your version of BaseLicenseStatusDialog to your version of BaseEquinoxPassageUI
  • which you can directly invoke from your own version of E4LicensingAddon or other places

Closes #1191

ImportLicenseDialog is extended with proper hooks
@eparovyshnaya eparovyshnaya added this to the 2.11.0 milestone Feb 18, 2024
Copy link

codecov bot commented Feb 18, 2024

Codecov Report

Attention: 159 lines in your changes are missing coverage. Please review.

Comparison is base (ed1229b) 33.75% compared to head (470e75b) 33.74%.

Files Patch % Lines
...ace/dialogs/licensing/BaseLicenseStatusDialog.java 0.00% 73 Missing ⚠️
...clipse/passage/lic/jface/BaseEquinoxPassageUI.java 0.00% 29 Missing ⚠️
...l/jface/dialogs/licensing/FromLocalFileSystem.java 0.00% 24 Missing ⚠️
...l/jface/dialogs/licensing/ImportLicenseDialog.java 0.00% 14 Missing ⚠️
...nternal/jface/dialogs/licensing/GoodIntention.java 0.00% 5 Missing ⚠️
...l/jface/dialogs/licensing/LicenseStatusDialog.java 0.00% 5 Missing ⚠️
...c/internal/jface/dialogs/licensing/LicenseSet.java 0.00% 4 Missing ⚠️
...ic/internal/base/conditions/LicenseConditions.java 0.00% 2 Missing ⚠️
...rg/eclipse/passage/lic/jface/EquinoxPassageUI.java 0.00% 2 Missing ⚠️
...e/dialogs/licensing/AllConditionsFromLicenses.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1285      +/-   ##
============================================
- Coverage     33.75%   33.74%   -0.02%     
  Complexity      391      391              
============================================
  Files          1181     1184       +3     
  Lines         25864    25883      +19     
  Branches       1591     1590       -1     
============================================
+ Hits           8731     8733       +2     
- Misses        16612    16630      +18     
+ Partials        521      520       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ImportLicenseDialog is extended with proper hooks
Copy link
Contributor

@ruspl-afed ruspl-afed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add headers for new files

Copy link
Contributor

@ruspl-afed ruspl-afed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Very desired feature!

@eparovyshnaya eparovyshnaya merged commit 3028013 into master Feb 19, 2024
4 of 6 checks passed
@ruspl-afed ruspl-afed deleted the 1191 branch February 19, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Import Licenses" wizard should support import from archive
2 participants