Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1147 Operator: get rid of javax.mail dependency #1149

Merged
merged 3 commits into from
Nov 17, 2022
Merged

1147 Operator: get rid of javax.mail dependency #1149

merged 3 commits into from
Nov 17, 2022

Conversation

eparovyshnaya
Copy link
Contributor

  • both interface lic.email, implementation lic.mail and test lic.mail.tests bundles are deleted
  • lic.mail.feature is deleted, all references cleaned up
  • releng aggregator put into accordance with the removals
  • dependency removed from targets

@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Merging #1149 (ebae55f) into master (82c8b45) will increase coverage by 0.11%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #1149      +/-   ##
============================================
+ Coverage     33.57%   33.69%   +0.11%     
  Complexity      359      359              
============================================
  Files          1161     1158       -3     
  Lines         25743    25589     -154     
  Branches       1592     1585       -7     
============================================
- Hits           8644     8622      -22     
+ Misses        16579    16447     -132     
  Partials        520      520              
Impacted Files Coverage Δ
...passage/lic/equinox/access/ConsoleInteraction.java 0.00% <ø> (ø)
.../dashboard/ui/wizards/IssueLicenseDetailsPage.java 0.00% <0.00%> (ø)
...e/loc/dashboard/ui/wizards/IssueLicenseWizard.java 0.00% <0.00%> (ø)
...rg/eclipse/passage/lic/bc/BcResidentSecretKey.java 95.65% <0.00%> (+4.34%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ruspl-afed
Copy link
Contributor

ruspl-afed commented Nov 17, 2022

both interface lic.email, implementation lic.mail and test lic.mail.tests bundles are deleted

I do not see all the annonced deletions in the PR.
Perhaps, we could keep the interface lic.email but remove only lic.mail implementation (to avoid major version increase).
Since we plan a lot of changes next year, I think we can postpone the interface removal

Copy link
Contributor

@ruspl-afed ruspl-afed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's restore API bundle for this release

releng/org.eclipse.passage.lic.aggregator/pom.xml Outdated Show resolved Hide resolved
features/org.eclipse.passage.lic.net.feature/feature.xml Outdated Show resolved Hide resolved
Copy link
Contributor

@ruspl-afed ruspl-afed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruspl-afed ruspl-afed merged commit d916996 into master Nov 17, 2022
@ruspl-afed ruspl-afed deleted the 1147 branch December 6, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants