Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

470 # Add instructions for contributors #1134

Merged
merged 1 commit into from
Oct 25, 2022
Merged

470 # Add instructions for contributors #1134

merged 1 commit into from
Oct 25, 2022

Conversation

eparovyshnaya
Copy link
Contributor

state 'ticket is mandatory for a commit'

ruspl-afed
ruspl-afed previously approved these changes Oct 25, 2022
Copy link
Contributor

@ruspl-afed ruspl-afed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @eparovyshnaya

@ruspl-afed
Copy link
Contributor

@eparovyshnaya please ensure ECA check is ok

@ruspl-afed ruspl-afed self-requested a review October 25, 2022 18:46
@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Merging #1134 (8539e81) into master (4d48202) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1134   +/-   ##
=========================================
  Coverage     33.21%   33.21%           
  Complexity      356      356           
=========================================
  Files          1161     1161           
  Lines         25699    25699           
  Branches       1588     1588           
=========================================
  Hits           8535     8535           
  Misses        16659    16659           
  Partials        505      505           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ruspl-afed ruspl-afed dismissed their stale review October 25, 2022 18:54

eclipsefdn/eca check is failing

state 'ticket is mandatory for a commit'
@eparovyshnaya
Copy link
Contributor Author

Just is case someone else grows curious as to why: explanation erroneously seemed to be redundant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants