Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused required bundle log4j from passage.loc.products.ui #1130

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

HannesWell
Copy link
Contributor

This was forgotten in #1121.

@codecov
Copy link

codecov bot commented Oct 7, 2022

Codecov Report

Merging #1130 (a978318) into master (aeec4af) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1130      +/-   ##
============================================
- Coverage     33.20%   33.20%   -0.01%     
  Complexity      356      356              
============================================
  Files          1161     1161              
  Lines         25699    25699              
  Branches       1588     1588              
============================================
- Hits           8534     8533       -1     
  Misses        16660    16660              
- Partials        505      506       +1     
Impacted Files Coverage Δ
...bc/internal/base/acquire/DefaultGrantsStorage.java 76.27% <0.00%> (-1.70%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@HannesWell
Copy link
Contributor Author

@ruspl-afed can you please review this PR?

Copy link
Contributor

@ruspl-afed ruspl-afed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruspl-afed ruspl-afed merged commit 3690624 into eclipse-passage:master Oct 12, 2022
@HannesWell HannesWell deleted the removeUnusedLog4j branch October 12, 2022 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants