Maintain collection-order in FeatureFilter and FeatureConditionPack #1112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensure the order implied by the order of services in the registry is maintained throughout the mining-process, as described in: eclipse-passage#1105
Codecov Report
@@ Coverage Diff @@
## master #1112 +/- ##
=========================================
Coverage 33.21% 33.21%
Complexity 356 356
=========================================
Files 1161 1161
Lines 25700 25700
Branches 1589 1589
=========================================
Hits 8536 8536
Misses 16659 16659
Partials 505 505
Continue to review full report at Codecov.
|
eparovyshnaya
approved these changes
Jul 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensure the order implied by the order of services in the registry is maintained throughout the mining-process, as described in:
#1105
@eparovyshnaya please have a look. I think it does not have a negative impact for Passage in general, but it would help me in my use-case. The documentation states nothing about if the element order is retained during filtering, therefore I think it is OK to change it from 'shuffling' to 'order-maintaining'. If you want, I can also add documentation that states that the order is now maintained.