Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1096 Computer.Model and Cpu.Model EnvironmentProperty share family and name #1098

Merged
merged 4 commits into from
Jun 25, 2022

Conversation

eparovyshnaya
Copy link
Contributor

computer properties belong to dedicated family

Closes #1096

@eparovyshnaya eparovyshnaya requested a review from ruspl-afed June 25, 2022 14:19
@codecov
Copy link

codecov bot commented Jun 25, 2022

Codecov Report

Merging #1098 (c4c38c5) into master (00bdb13) will increase coverage by 0.10%.
The diff coverage is 97.56%.

@@             Coverage Diff              @@
##             master    #1098      +/-   ##
============================================
+ Coverage     33.12%   33.22%   +0.10%     
- Complexity      352      356       +4     
============================================
  Files          1159     1160       +1     
  Lines         25648    25686      +38     
  Branches       1589     1589              
============================================
+ Hits           8495     8535      +40     
+ Misses        16648    16646       -2     
  Partials        505      505              
Impacted Files Coverage Δ
...e/lic/base/inspection/BaseEnvironmentProperty.java 75.00% <50.00%> (ø)
...ic/internal/base/inspection/hardware/Computer.java 100.00% <100.00%> (ø)
.../tests/inspection/hardware/OshiPropertiesTest.java 100.00% <100.00%> (ø)
...age/lic/internal/base/inspection/hardware/Cpu.java 100.00% <0.00%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00bdb13...c4c38c5. Read the comment docs.

@ruspl-afed
Copy link
Contributor

thank you @eparovyshnaya
as I can see from the test - it confirms that each property has unique family+name combination

@eparovyshnaya eparovyshnaya merged commit 8467b7d into master Jun 25, 2022
@ruspl-afed ruspl-afed deleted the 1096 branch August 21, 2022 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Computer.Model and Cpu.Model EnvironmentProperty share family and name
2 participants