Fix FLS console input on Linux: #1081 #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConsoleInteraction.java waits for the carriage return character (ASCII 13) before accepting input. Linux indicates input with the line feed character (ASCII 10). Checking for either ASCII 10 or ASCII 13 allows input to be accepted on Unix, Windows, and Mac
eparovyshnaya
requested review from
eparovyshnaya and
zelenyhleb
and removed request for
eparovyshnaya
zelenyhleb
approved these changes
Apr 22, 2022
|
Left untested, the fix appeared to completely break Windows version of FLS #1142. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConsoleInteraction.java waits for the carriage return character (ASCII 13) before accepting input. Linux indicates input with the line feed character (ASCII 10). Checking for either ASCII 10 or ASCII 13 allows input to be accepted on Unix, Windows, and Mac