Remove unused Require-Bundle: org.slf4j.api #1079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1079 +/- ##
=========================================
Coverage 33.08% 33.08%
Complexity 346 346
=========================================
Files 1156 1156
Lines 25612 25612
Branches 1588 1588
=========================================
Hits 8473 8473
Misses 16635 16635
Partials 504 504 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like
org.eclipse.passage.lic.oshiand its tests do not use the slf4j API and the requirement to it can therefore be removed.If there is another reason, that I oversaw, to wire to a slf4j bundle I suggest to use Import-Package instead. That allows consumers to use another slf4j bundle than the one provided at Eclipse-Orbit.