Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1030: take care of not released grants #1033

Merged
merged 6 commits into from
Feb 13, 2022
Merged

1030: take care of not released grants #1033

merged 6 commits into from
Feb 13, 2022

Conversation

eparovyshnaya
Copy link
Contributor

ForsakenGrantsService is designed, implemented and invoked on grant aqcuisition/release cycle

add dedicated service to ACC
- remember unreleased grant
- try to release all those (if any) on each acquire
implement forsaken grants service
@@ -90,15 +90,15 @@ TYPE_PARAMETER_ELEMENT_TYPE_REMOVED_CLASS_BOUND=Error
TYPE_PARAMETER_ELEMENT_TYPE_REMOVED_INTERFACE_BOUND=Error
UNUSED_PROBLEM_FILTERS=Warning
automatically_removed_unused_problem_filters=false
changed_execution_env=Error
changed_execution_env=Warning
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we revert them back after 2.3.0?

supply acquires to base service in a lazy way
@codecov
Copy link

codecov bot commented Feb 13, 2022

Codecov Report

Merging #1033 (c2ecc7e) into master (2ec8a60) will decrease coverage by 0.00%.
The diff coverage is 36.79%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1033      +/-   ##
============================================
- Coverage     33.39%   33.39%   -0.01%     
  Complexity      346      346              
============================================
  Files          1134     1138       +4     
  Lines         25144    25247     +103     
  Branches       1557     1568      +11     
============================================
+ Hits           8397     8431      +34     
- Misses        16256    16319      +63     
- Partials        491      497       +6     
Impacted Files Coverage Δ
...assage/lac/internal/gear/RuntimeConfiguration.java 0.00% <0.00%> (ø)
...passage/lic/base/acquire/BaseGrantAcquisition.java 100.00% <ø> (ø)
...al/base/tests/requirements/SabotagedFramework.java 27.27% <0.00%> (-1.30%) ⬇️
...se/passage/lic/internal/base/access/Residence.java 13.63% <13.63%> (ø)
...ipse/passage/lic/internal/base/access/Conduit.java 37.50% <37.50%> (ø)
...ipse/passage/lic/internal/base/access/Storage.java 47.36% <47.36%> (ø)
.../internal/base/access/UnreleasedGrantsService.java 69.23% <69.23%> (ø)
.../src/org/eclipse/passage/lic/base/access/Lock.java 54.79% <70.00%> (+0.24%) ⬆️
...sage/lic/execute/BaseAccessCycleConfiguration.java 100.00% <100.00%> (ø)
...rg/eclipse/passage/lic/bc/BcResidentSecretKey.java 91.30% <0.00%> (-4.35%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ec8a60...c2ecc7e. Read the comment docs.

@ruspl-afed ruspl-afed merged commit a811f05 into master Feb 13, 2022
@eparovyshnaya eparovyshnaya deleted the 1030 branch February 27, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants