-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1030: take care of not released grants #1033
Conversation
add dedicated service to ACC
- remember unreleased grant - try to release all those (if any) on each acquire
update lic headers
implement forsaken grants service
@@ -90,15 +90,15 @@ TYPE_PARAMETER_ELEMENT_TYPE_REMOVED_CLASS_BOUND=Error | |||
TYPE_PARAMETER_ELEMENT_TYPE_REMOVED_INTERFACE_BOUND=Error | |||
UNUSED_PROBLEM_FILTERS=Warning | |||
automatically_removed_unused_problem_filters=false | |||
changed_execution_env=Error | |||
changed_execution_env=Warning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we revert them back after 2.3.0?
in was an accident!11
supply acquires to base service in a lazy way
Codecov Report
@@ Coverage Diff @@
## master #1033 +/- ##
============================================
- Coverage 33.39% 33.39% -0.01%
Complexity 346 346
============================================
Files 1134 1138 +4
Lines 25144 25247 +103
Branches 1557 1568 +11
============================================
+ Hits 8397 8431 +34
- Misses 16256 16319 +63
- Partials 491 497 +6
Continue to review full report at Codecov.
|
ForsakenGrantsService
is designed, implemented and invoked on grant aqcuisition/release cycle