Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evolve raw string identifier to semantic entity #1453

Closed
eparovyshnaya opened this issue Oct 29, 2024 · 1 comment
Closed

Evolve raw string identifier to semantic entity #1453

eparovyshnaya opened this issue Oct 29, 2024 · 1 comment
Assignees
Labels
component::api Eclipse Passage API
Milestone

Comments

@eparovyshnaya
Copy link
Contributor

Originally we designated raw string identifiers to convey user-product licensing decisions to Passage Runtime Engine.

Production practice of Passage integrations maintenance reveals that raw string identifier approach lacks semantic severely and thus affects one of the most critical integration feat.

Support reports direct correlation between absence of differentiating for raw string identifiers - on one hand, and elongated implementation time with higher expences - on the other.

Hereby it is agreed to take steps to improve codebase in this aspect by eliminating raw strings that serve as identifiers for licensing configuration information and replacing them with entities that are to carry not only string information, but also shoulder semantic weight.

Key focus should rest with integration API: Passage interface, Access Cycle configuration interfaces and all the surronding facilities that developer of a product uses to protect the product with Passage.

The rest of API also should be revised from this perspective, as integration experience proves again and again that practically each extension point of the Passage Runtime Engine gets used every so often.

@eparovyshnaya eparovyshnaya added this to the 4.0.0 milestone Oct 29, 2024
@eparovyshnaya eparovyshnaya changed the title Evolve _raw string identifier_ to semantic entity Evolve raw string identifier to semantic entity Oct 29, 2024
@eparovyshnaya eparovyshnaya added the component::api Eclipse Passage API label Oct 29, 2024
ruspl-afed added a commit that referenced this issue Nov 10, 2024
Rework `String` feature identifier to a dedicated type
`FeatureIdentifier`
ruspl-afed added a commit that referenced this issue Nov 10, 2024
Rework `String` feature identifier to a dedicated type
`FeatureIdentifier`
ruspl-afed added a commit that referenced this issue Nov 11, 2024
Rework `String` feature identifier to a dedicated type
`FeatureIdentifier`
ruspl-afed added a commit that referenced this issue Nov 11, 2024
Rework `String` feature identifier to a dedicated type
`FeatureIdentifier`
ruspl-afed added a commit that referenced this issue Nov 11, 2024
Rework `String` feature identifier to a dedicated type
`FeatureIdentifier`
ruspl-afed added a commit that referenced this issue Nov 11, 2024
Rework `String` feature identifier to a dedicated type
`FeatureIdentifier`
ruspl-afed added a commit that referenced this issue Nov 11, 2024
Rework `String` feature identifier to a dedicated type
`FeatureIdentifier`
eparovyshnaya pushed a commit that referenced this issue Nov 12, 2024
Rework `String` feature identifier to a dedicated type
`FeatureIdentifier`
ruspl-afed added a commit that referenced this issue Nov 13, 2024
Rework `String` grant identifier to a dedicated type
`GrantIdentifier`
zelenyhleb pushed a commit that referenced this issue Nov 13, 2024
Rework `String` grant identifier to a dedicated type
`GrantIdentifier`
ruspl-afed added a commit that referenced this issue Nov 13, 2024
Rework `String` grant identifier to a dedicated type `UserIdentifier`
ruspl-afed added a commit that referenced this issue Nov 13, 2024
Rework `String` grant identifier to a dedicated type `UserIdentifier`
@ruspl-afed
Copy link
Contributor

Fixed. See #1459 , #1461 and #1463 regarding required test enchantments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component::api Eclipse Passage API
Projects
None yet
Development

No branches or pull requests

2 participants