Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete marker interface Gear #1372

Closed
eparovyshnaya opened this issue May 23, 2024 · 3 comments · Fixed by #1373 or #1374
Closed

Delete marker interface Gear #1372

eparovyshnaya opened this issue May 23, 2024 · 3 comments · Fixed by #1373 or #1374
Assignees
Labels
component::api Eclipse Passage API
Milestone

Comments

@eparovyshnaya
Copy link
Contributor

eparovyshnaya commented May 23, 2024

Notion of Gear was intended to supply a passage-related product with passage core services for this product's needs.

Appropriate interface was created in lic.api and used by both examplary passage-related products: FLS and Licensing Operator.

Practice shows that while notion itself is useful (yet questionable), the interface is fruitless. Each product has its own evolution and own way of getting, using, ungetting services, own set of services. Products are not intended to be alike in any sense.

Thus, Gear interface just lays a burden, introduces unnecessary connection - and brings noting useful to a product.

Gear and its supplier interfaces are subject for removal.

@ruspl-afed
Copy link
Contributor

Missed since 3.0 annotation for GearAware

@ruspl-afed ruspl-afed reopened this May 23, 2024
ruspl-afed added a commit that referenced this issue May 23, 2024
Missed since 3.0 annotation for `GearAware.Unsafe#apply`

Closes #1372
@eparovyshnaya
Copy link
Contributor Author

All gear-related services must also be removed from public API.

ruspl-afed added a commit that referenced this issue May 23, 2024
Missed since 3.0 annotation for `GearAware.Unsafe#apply`

Closes #1372
@ruspl-afed
Copy link
Contributor

All gear-related services must also be removed from public API.

Oops, reopened again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component::api Eclipse Passage API
Projects
None yet
2 participants