Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Net emf objects transfer should rely on domain resource factory #1334

Closed
eparovyshnaya opened this issue Apr 4, 2024 · 0 comments · Fixed by #1335
Closed

Net emf objects transfer should rely on domain resource factory #1334

eparovyshnaya opened this issue Apr 4, 2024 · 0 comments · Fixed by #1335
Assignees
@eparovyshnaya
Labels
component::runtime Passage Licensing Runtime (LIC): reused accross other components technical debt
Milestone
3.0.0

Comments

@eparovyshnaya
Copy link
Contributor

Often we transfer license-related EMF objects as a payload to net response.
Such a serialization does not require resource URI to show in the picture, so we use direct resource implementation invocation.

This is not how things should work.

Make an effort and retrieve resource instance from a factory, not reference it directly.
Central facility is EObjectToBytes, all its clients also need revision.
@eparovyshnaya eparovyshnaya added this to the 2.12.0 milestone Apr 4, 2024
@eparovyshnaya eparovyshnaya self-assigned this Apr 4, 2024
@eparovyshnaya eparovyshnaya added the component::runtime Passage Licensing Runtime (LIC): reused accross other components label Apr 4, 2024
eparovyshnaya added a commit that referenced this issue Apr 4, 2024
@eparovyshnaya
[#1334] Net emf objects transfer should rely on domain resource factory
49a06a3 
Signed-off-by: eparovyshnaya <[email protected]>
eparovyshnaya added a commit that referenced this issue Apr 4, 2024
@eparovyshnaya
[#1334] Net emf objects transfer should rely on domain resource factory
3303be7 
Signed-off-by: eparovyshnaya <[email protected]>
eparovyshnaya added a commit that referenced this issue Apr 4, 2024
@eparovyshnaya
[#1334] Net emf objects transfer should rely on domain resource factory
c5c3ee7 
Signed-off-by: eparovyshnaya <[email protected]>
eparovyshnaya added a commit that referenced this issue Apr 4, 2024
@eparovyshnaya
[#1334] Net emf objects transfer should rely on domain resource factory
c386419 
Signed-off-by: eparovyshnaya <[email protected]>
@eparovyshnaya eparovyshnaya mentioned this issue Apr 4, 2024
Merged
eparovyshnaya added a commit that referenced this issue Apr 5, 2024
@eparovyshnaya
[#1334] Net emf objects transfer should rely on domain resource factory
11c5bb7 
Signed-off-by: eparovyshnaya <[email protected]>
eparovyshnaya added a commit that referenced this issue Apr 5, 2024
@eparovyshnaya
[#1334] Net emf objects transfer should rely on domain resource factory
1d251a1 
Signed-off-by: eparovyshnaya <[email protected]>
eparovyshnaya added a commit that referenced this issue Apr 5, 2024
@eparovyshnaya
[#1334] Net emf objects transfer should rely on domain resource factory
bad42b7 
Signed-off-by: eparovyshnaya <[email protected]>
eparovyshnaya added a commit that referenced this issue Apr 5, 2024
@eparovyshnaya
[#1334] Net emf objects transfer should rely on domain resource factory
d8a2dab 
Signed-off-by: eparovyshnaya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eparovyshnaya eparovyshnaya

Labels
component::runtime Passage Licensing Runtime (LIC): reused accross other components technical debt
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

[#1334] Net emf objects transfer should rely on domain resource factory eclipse-passage/passage
1 participant
@eparovyshnaya