Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misprints in licensing requirement level should be treated as fatal #1330

Closed
ruspl-afed opened this issue Mar 26, 2024 · 3 comments · Fixed by #1331
Closed

Misprints in licensing requirement level should be treated as fatal #1330

ruspl-afed opened this issue Mar 26, 2024 · 3 comments · Fixed by #1331
Assignees
Milestone

Comments

@ruspl-afed
Copy link
Contributor

Define product startup requirement like

Provide-Capability: licensing.feature;licensing.feature="my.product";name="My Product";version="1.0.0";provider="Me";agreements="licenses/EULA.txt";level="warn"

Here we have warn level instead of warning

Actual:
No check at all

Expected:
Let's treat as fatal

@ruspl-afed ruspl-afed added this to the 2.11.1 milestone Mar 26, 2024
@ruspl-afed ruspl-afed added the priority::high Priority: HIGH label Mar 26, 2024
@eparovyshnaya eparovyshnaya self-assigned this Mar 26, 2024
@eparovyshnaya
Copy link
Contributor

eparovyshnaya commented Mar 26, 2024

@ruspl-afed
Actually we already treat anything unknown as more severe than fatal.

There is a test for the case - unexpectedRestrictionLevelFailureIsContageous.

And I cannot observe described behavior.
Can there be any other reason for the case, or some other significant detail to the scenario?

@eparovyshnaya
Copy link
Contributor

eparovyshnaya commented Mar 26, 2024

It appeared that warn is actually valid designation for RestrictionLevel.Warning, and warning is not :)

So in this case tentative access has been granted.
And it is treated sufficient due to the recent fix #1282.

Definitely, warning restriction leven should cause more inconvenience.

eparovyshnaya added a commit that referenced this issue Mar 26, 2024
Misprints in licensing requirement level should be treated as fatal

warning-restrictions also treated as signs of insufficient coverage
ruspl-afed pushed a commit that referenced this issue Mar 26, 2024
Misprints in licensing requirement level should be treated as fatal

warning-restrictions also treated as signs of insufficient coverage
@eparovyshnaya eparovyshnaya removed the priority::high Priority: HIGH label Mar 27, 2024
@eparovyshnaya
Copy link
Contributor

remove 'high priority' label as it appears to be minor disfunction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants