Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Employ Eclipse Dash license check #1161

Closed
ruspl-afed opened this issue Nov 26, 2022 · 2 comments
Closed

Employ Eclipse Dash license check #1161

ruspl-afed opened this issue Nov 26, 2022 · 2 comments
Assignees
@ruspl-afed
Milestone
2.7.0

Comments

@ruspl-afed
Copy link
Contributor

Let's try to automate 3rd party license check
@ruspl-afed ruspl-afed self-assigned this Nov 26, 2022
ruspl-afed added a commit that referenced this issue Nov 26, 2022
@ruspl-afed
Employ Eclipse Dash license check #1161
76a1934 
add licensecheck.yml to call
org.eclipse.dash:license-tool-plugin:license-check

Signed-off-by: Alexander Fedorov <[email protected]>
ruspl-afed added a commit that referenced this issue Nov 26, 2022
@ruspl-afed
Employ Eclipse Dash license check #1161
064c945 
Redirect call to
eclipse/dash-licenses/.github/workflows/mavenLicenseCheck.yml@master

Signed-off-by: Alexander Fedorov <[email protected]>
ruspl-afed added a commit that referenced this issue Nov 27, 2022
@ruspl-afed
Employ Eclipse Dash license check #1161
381bcda 
Try to use tycho project id

Signed-off-by: Alexander Fedorov <[email protected]>
ruspl-afed added a commit that referenced this issue Nov 27, 2022
@ruspl-afed
Employ Eclipse Dash license check #1161
d182f94 
Revert back to direct maven plugin call

Signed-off-by: Alexander Fedorov <[email protected]>
ruspl-afed added a commit that referenced this issue Nov 27, 2022
@ruspl-afed
Employ Eclipse Dash license check #1161
6920c47 
Correct repository

Signed-off-by: Alexander Fedorov <[email protected]>
eparovyshnaya added a commit that referenced this issue Nov 28, 2022
@eparovyshnaya
Merge pull request #1162 from eclipse-passage/1161
0d74f06 
Employ Eclipse Dash license check #1161
@HannesWell
Copy link
Contributor

If you are interested, I created a re-usable GH-workflow that requires almost no setup and allows to request license-vetting interactively by commenting on the PR:
https://github.com/eclipse/dash-licenses/tree/master/.github

You can see it for example in M2E:
https://github.com/eclipse-m2e/m2e-core/blob/master/.github/workflows/licensecheck.yml
But it is also used in the Platform-Aggregator and in Tycho.
Besides the workflow you only have to ask the EF-Infra team for a IP-Lap token for passage, just like in:
https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/1464

@ruspl-afed ruspl-afed added this to the 2.7.0 milestone Apr 14, 2023
@ruspl-afed
Copy link
Contributor Author

Done with #1162

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruspl-afed ruspl-afed

Labels
None yet
Projects
None yet
Milestone
2.7.0
Development

No branches or pull requests
2 participants
@ruspl-afed @HannesWell