Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License agreement restrictions must be emitted with restrictive level #1146

Closed
eparovyshnaya opened this issue Nov 16, 2022 · 1 comment · Fixed by #1165
Closed

License agreement restrictions must be emitted with restrictive level #1146

eparovyshnaya opened this issue Nov 16, 2022 · 1 comment · Fixed by #1165
Assignees
Labels
bug Something isn't working component::runtime Passage Licensing Runtime (LIC): reused accross other components
Milestone

Comments

@eparovyshnaya
Copy link
Contributor

Currently, if a user has not yet accepted a license agreement, Access Cycle emits restriction of WARN level, and that's confusing.

As the intension is to prohibit an agreement unaware usage of a product or a feature, then corresponding restrictions must have forbidding level (ERROR or FATAL)

@eparovyshnaya eparovyshnaya added bug Something isn't working component::runtime Passage Licensing Runtime (LIC): reused accross other components labels Nov 16, 2022
@eparovyshnaya eparovyshnaya added this to the 2.6.0 milestone Nov 16, 2022
@eparovyshnaya eparovyshnaya self-assigned this Nov 16, 2022
eparovyshnaya added a commit that referenced this issue Nov 27, 2022
level #1146

describe the [not accepted] state properly
@eparovyshnaya eparovyshnaya changed the title License agreement restrictions must be emitter with restrictive level License agreement restrictions must be emitted with restrictive level Nov 27, 2022
ruspl-afed added a commit that referenced this issue Nov 27, 2022
License agreement restrictions must be emitted with restrictive level #1146
@eparovyshnaya
Copy link
Contributor Author

We always emitt agreement not accepted restrictions with FATAL restriction level.

In this particular case warn appeared in the log because of the feature, that demands this agreement to be accepted. Feature itself declares its own restriction level as warn.

Thus the fix boiled up to log extension. Now unaccepted agreement reported this way:

Agreements state contains 1 entries.
  agreement [licenses/epl-2.0.txt]
  declared by [BaseRequirement [feature=BaseFeature [id=org.eclipse.passage.loc.operator.product, version=2.6.0, name=Eclipse Passage Operator, provider=Eclispe Passage], restriction=warn, source=org.eclipse.passage.loc.operator]]
  has [not accepted] state.
  This is FATAL!11. Product cannot proceed without the agreement been accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component::runtime Passage Licensing Runtime (LIC): reused accross other components
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant