Merge pull request #258 from eclipse-passage/564420

Bug 564420 move HC condition miner to new interfaces
eclipse-passage · Jun 21, 2020 · cce89c9 · cce89c9
2 parents 68ea240 + 9d04b5c
commit cce89c9
Show file tree

Hide file tree

Showing 14 changed files with 34 additions and 15 deletions.
diff --git a/tests/org.eclipse.passage.lic.api.tests/META-INF/MANIFEST.MF b/tests/org.eclipse.passage.lic.api.tests/META-INF/MANIFEST.MF
@@ -9,6 +9,6 @@ Bundle-Copyright: %Bundle-Copyright
 Bundle-RequiredExecutionEnvironment: JavaSE-1.8
 Require-Bundle: org.junit;bundle-version="4.12.0",
  org.eclipse.passage.lic.api;bundle-version="0.7.0"
-Export-Package: org.eclipse.passage.lic.api.conditions.tests;x-internal:=true,
- org.eclipse.passage.lic.api.tests;x-internal:=true,
- org.eclipse.passage.lic.api.version.tests;x-internal:=true
+Export-Package: org.eclipse.passage.lic.api.tests;x-internal:=true,
+ org.eclipse.passage.lic.api.tests.conditions;x-internal:=true,
+ org.eclipse.passage.lic.api.tests.version;x-internal:=true
diff --git a/...ons/tests/EvaluationTypeContractTest.java → ...onditions/EvaluationTypeContractTest.java b/...ons/tests/EvaluationTypeContractTest.java → ...onditions/EvaluationTypeContractTest.java
@@ -10,7 +10,7 @@
  * Contributors:
  *     ArSysOp - initial API and implementation
  *******************************************************************************/
-package org.eclipse.passage.lic.api.conditions.tests;
+package org.eclipse.passage.lic.api.tests.conditions;
 
 import static org.junit.Assert.assertEquals;
 

diff --git a/...s/tests/EvaluationTypeOfContractTest.java → ...ditions/EvaluationTypeOfContractTest.java b/...s/tests/EvaluationTypeOfContractTest.java → ...ditions/EvaluationTypeOfContractTest.java
@@ -10,7 +10,7 @@
  * Contributors:
  *     ArSysOp - initial API and implementation
  *******************************************************************************/
-package org.eclipse.passage.lic.api.conditions.tests;
+package org.eclipse.passage.lic.api.tests.conditions;
 
 import org.eclipse.passage.lic.internal.api.conditions.EvaluationType;
 

diff --git a/...tions/tests/MatchingRuleContractTest.java → .../conditions/MatchingRuleContractTest.java b/...tions/tests/MatchingRuleContractTest.java → .../conditions/MatchingRuleContractTest.java
@@ -10,7 +10,7 @@
  * Contributors:
  *     ArSysOp - initial API and implementation
  *******************************************************************************/
-package org.eclipse.passage.lic.api.conditions.tests;
+package org.eclipse.passage.lic.api.tests.conditions;
 
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertTrue;

diff --git a/...sts/ValidityPeriodClosedContractTest.java → ...ons/ValidityPeriodClosedContractTest.java b/...sts/ValidityPeriodClosedContractTest.java → ...ons/ValidityPeriodClosedContractTest.java
@@ -10,7 +10,7 @@
  * Contributors:
  *     ArSysOp - initial API and implementation
  *******************************************************************************/
-package org.eclipse.passage.lic.api.conditions.tests;
+package org.eclipse.passage.lic.api.tests.conditions;
 
 import static org.junit.Assert.assertTrue;
 

diff --git a/...ons/tests/ValidityPeriodContractTest.java → ...onditions/ValidityPeriodContractTest.java b/...ons/tests/ValidityPeriodContractTest.java → ...onditions/ValidityPeriodContractTest.java
@@ -10,7 +10,7 @@
  * Contributors:
  *     ArSysOp - initial API and implementation
  *******************************************************************************/
-package org.eclipse.passage.lic.api.conditions.tests;
+package org.eclipse.passage.lic.api.tests.conditions;
 
 import static org.junit.Assert.assertFalse;
 import static org.junit.Assert.assertTrue;

diff --git a/...tests/ValidityPeriodOpenContractTest.java → ...tions/ValidityPeriodOpenContractTest.java b/...tests/ValidityPeriodOpenContractTest.java → ...tions/ValidityPeriodOpenContractTest.java
@@ -10,7 +10,7 @@
  * Contributors:
  *     ArSysOp - initial API and implementation
  *******************************************************************************/
-package org.eclipse.passage.lic.api.conditions.tests;
+package org.eclipse.passage.lic.api.tests.conditions;
 
 import static org.junit.Assert.assertEquals;
 

diff --git a/...on/tests/SemanticVersionContractTest.java → .../version/SemanticVersionContractTest.java b/...on/tests/SemanticVersionContractTest.java → .../version/SemanticVersionContractTest.java
@@ -10,7 +10,7 @@
  * Contributors:
  *     ArSysOp - initial API and implementation
  *******************************************************************************/
-package org.eclipse.passage.lic.api.version.tests;
+package org.eclipse.passage.lic.api.tests.version;
 
 import static org.junit.Assert.assertNotNull;
 import static org.junit.Assume.assumeFalse;

diff --git a/...pi/version/tests/VersionContractTest.java → ...pi/tests/version/VersionContractTest.java b/...pi/version/tests/VersionContractTest.java → ...pi/tests/version/VersionContractTest.java
@@ -10,7 +10,7 @@
  * Contributors:
  *     ArSysOp - initial API and implementation
  *******************************************************************************/
-package org.eclipse.passage.lic.api.version.tests;
+package org.eclipse.passage.lic.api.tests.version;
 
 import static org.junit.Assert.assertFalse;
 import static org.junit.Assert.assertTrue;

diff --git a/...ic.base.tests/src/org/eclipse/passage/lic/internal/base/conditions/BaseConditionTest.java b/...ic.base.tests/src/org/eclipse/passage/lic/internal/base/conditions/BaseConditionTest.java
@@ -12,8 +12,12 @@
  *******************************************************************************/
 package org.eclipse.passage.lic.internal.base.conditions;
 
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
+
 import java.util.Date;
 
+import org.eclipse.passage.lic.internal.api.conditions.Condition;
 import org.eclipse.passage.lic.internal.api.conditions.EvaluationInstructions;
 import org.eclipse.passage.lic.internal.api.conditions.EvaluationType;
 import org.eclipse.passage.lic.internal.api.conditions.ValidityPeriod;
@@ -59,6 +63,21 @@ public void evaluationInstructionsAreMandatory() {
 		new BaseCondition(feature(), versionMatch(), validityPeriod(), null);
 	}
 
+	@Test
+	public void isDataTransitionObject() {
+		// given
+		VersionMatch match = versionMatch();
+		ValidityPeriod period = validityPeriod();
+		EvaluationInstructions instructions = evaluationInstructions();
+		// when
+		Condition condition = new BaseCondition(feature(), match, period, instructions);
+		// then
+		assertEquals(feature(), condition.feature());
+		assertTrue(match == condition.versionMatch());
+		assertTrue(period == condition.validityPeriod());
+		assertTrue(instructions == condition.evaluationInstructions());
+	}
+
 	private String feature() {
 		return "test-feature"; //$NON-NLS-1$
 	}

diff --git a/...g/eclipse/passage/lic/internal/base/conditions/contract/BaseMatchingRuleContractTest.java b/...g/eclipse/passage/lic/internal/base/conditions/contract/BaseMatchingRuleContractTest.java
@@ -12,7 +12,7 @@
  *******************************************************************************/
 package org.eclipse.passage.lic.internal.base.conditions.contract;
 
-import org.eclipse.passage.lic.api.conditions.tests.MatchingRuleContractTest;
+import org.eclipse.passage.lic.api.tests.conditions.MatchingRuleContractTest;
 import org.junit.Test;
 
 @SuppressWarnings("restriction")

diff --git a/...eclipse/passage/lic/internal/base/conditions/contract/BaseValidityPeriodContractTest.java b/...eclipse/passage/lic/internal/base/conditions/contract/BaseValidityPeriodContractTest.java
@@ -14,7 +14,7 @@
 
 import java.util.Date;
 
-import org.eclipse.passage.lic.api.conditions.tests.ValidityPeriodClosedContractTest;
+import org.eclipse.passage.lic.api.tests.conditions.ValidityPeriodClosedContractTest;
 import org.eclipse.passage.lic.internal.api.conditions.ValidityPeriodClosed;
 import org.eclipse.passage.lic.internal.base.conditions.BaseValidityPeriodClosed;
 

diff --git a/...pse/passage/lic/internal/base/tests/version/contract/BaseSemanticVersionContractTest.java b/...pse/passage/lic/internal/base/tests/version/contract/BaseSemanticVersionContractTest.java
@@ -12,7 +12,7 @@
  *******************************************************************************/
 package org.eclipse.passage.lic.internal.base.tests.version.contract;
 
-import org.eclipse.passage.lic.api.version.tests.SemanticVersionContractTest;
+import org.eclipse.passage.lic.api.tests.version.SemanticVersionContractTest;
 import org.eclipse.passage.lic.internal.api.version.SemanticVersion;
 import org.eclipse.passage.lic.internal.base.version.BaseSemanticVersion;
 

diff --git a/...org/eclipse/passage/lic/internal/base/tests/version/contract/SafeVersionContractTest.java b/...org/eclipse/passage/lic/internal/base/tests/version/contract/SafeVersionContractTest.java
@@ -12,7 +12,7 @@
  *******************************************************************************/
 package org.eclipse.passage.lic.internal.base.tests.version.contract;
 
-import org.eclipse.passage.lic.api.version.tests.VersionContractTest;
+import org.eclipse.passage.lic.api.tests.version.VersionContractTest;
 import org.eclipse.passage.lic.internal.api.version.Version;
 import org.eclipse.passage.lic.internal.base.version.SafeVersion;