Skip to content

Commit

Permalink
Remove SLF4J Plugin from o.e.passage.lic.oshi feature
Browse files Browse the repository at this point in the history
If a Feature includes a Plugin, it usually includes it with a specific
name and the version that was in the TP when the feature was build.
This prevents consumers from using a slf4j bundle with different
symbolic-name or different version in their TP or product.

This is part of
eclipse-platform/eclipse.platform.releng.aggregator#588
  • Loading branch information
HannesWell committed Oct 8, 2022
1 parent aeec4af commit 6952e40
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 7 deletions.
7 changes: 7 additions & 0 deletions features/org.eclipse.passage.lbc.target.feature/feature.xml
Original file line number Diff line number Diff line change
Expand Up @@ -66,4 +66,11 @@
version="0.0.0"
unpack="false"/>

<plugin
id="org.slf4j.api"
download-size="0"
install-size="0"
version="0.0.0"
unpack="false"/>

</feature>
7 changes: 0 additions & 7 deletions features/org.eclipse.passage.lic.oshi.feature/feature.xml
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,6 @@
<import feature="org.eclipse.passage.lic.equinox.feature" version="0.0.0"/>
</requires>

<plugin
id="org.slf4j.api"
download-size="0"
install-size="0"
version="0.0.0"
unpack="false"/>

<plugin
id="com.sun.jna"
download-size="0"
Expand Down
2 changes: 2 additions & 0 deletions releng/org.eclipse.passage.ldc.repository/category.xml
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,6 @@
id="org.eclipse.passage.ldc.feature.source">
<category name="org.eclipse.passage.ldc.category.source" />
</feature>
<bundle id="org.slf4j.api"/>
<bundle id="org.slf4j.api.source"/>
</site>
2 changes: 2 additions & 0 deletions releng/org.eclipse.passage.lic.repository/category.xml
Original file line number Diff line number Diff line change
Expand Up @@ -69,4 +69,6 @@
id="org.eclipse.passage.lic.jetty.feature.source">
<category name="org.eclipse.passage.lic.category.source" />
</feature>
<bundle id="org.slf4j.api"/>
<bundle id="org.slf4j.api.source"/>
</site>

0 comments on commit 6952e40

Please sign in to comment.