Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove schema service mocking, update service URL path #1180

Merged
merged 2 commits into from
Apr 25, 2023
Merged

Remove schema service mocking, update service URL path #1180

merged 2 commits into from
Apr 25, 2023

Conversation

jabrah
Copy link
Contributor

@jabrah jabrah commented Apr 20, 2023

Seems to work to make requests, but the service in pass-core is not ready yet

@jabrah jabrah requested a review from jaredgalanis April 20, 2023 13:31
@jabrah jabrah mentioned this pull request Apr 20, 2023
Closed
jaredgalanis
jaredgalanis approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@jaredgalanis jaredgalanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving conditionally while tests are being fixed

@jabrah jabrah merged commit 96965f4 into main Apr 25, 2023
@jabrah jabrah deleted the 458-schema-service-integration branch April 25, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredgalanis jaredgalanis jaredgalanis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jabrah @jaredgalanis