Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to run pass-docker in JHU AWS stage environment #345

Merged
merged 10 commits into from
Jul 28, 2023

Conversation

rpoet-jh
Copy link
Contributor

@rpoet-jh rpoet-jh commented Jul 26, 2023

DO NOT MERGE UNTIL 0.8.0 RELEASE IS DONE

eclipse-pass/main#630

The main changes made are as follows:

  • Refactor compose files to use overlays to include appropriate services depending on targeted environment
  • Reorganize env files to assume common services for all environments as base and overlay on that

**Important note: To run pass-docker locally, the args have changed, see README. Changes will be needed in the deployment script to run local env which I have talked with Christopher about. **

@rpoet-jh rpoet-jh requested review from markpatton and jabrah July 26, 2023 13:49
@rpoet-jh rpoet-jh self-assigned this Jul 26, 2023
@rpoet-jh
Copy link
Contributor Author

In the ticket, there is this item Send logs to cloudwatch. This will be done when we transition to using ECS for deployment, it is not part of this PR.

@markpatton markpatton linked an issue Jul 26, 2023 that may be closed by this pull request
@rpoet-jh rpoet-jh force-pushed the russ-630-aws-deploy-config branch from 921c8bf to de0ba80 Compare July 27, 2023 18:47
Copy link
Contributor

@markpatton markpatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible. I was able to run it locally.

@rpoet-jh rpoet-jh merged commit df39b6b into main Jul 28, 2023
@rpoet-jh rpoet-jh deleted the russ-630-aws-deploy-config branch August 1, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change pass-docker to start in non-local mode
2 participants