Paramaterizing tag values and removing hashes from docker-compose.yml #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jabrah
requested changes
Apr 5, 2023
There was a problem hiding this comment.
TAGis unique in this case and is unlikely to be used elsewhere, but we might want a bit more descriptive name, maybe likePASS_VERSION?- Could you add the new env var to the
.envfile so there's a value provided automatically? We could set it to0.4.0for now, matching what the various tags were before, possibly updating it later to0.4.0-SNAPSHOT(I'm just not sure if everything has a -SNAPSHOT version published yet) - Can you update the docker command to spin up the environment to
docker compose up -d --no-build --quiet-pull --pull always- In the README
- In
.github/workflows/pass-acceptance-tests.yml
|
Made the changes requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.