Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pass-core env config #309

Merged
merged 2 commits into from
Jan 10, 2023
Merged

Update pass-core env config #309

merged 2 commits into from
Jan 10, 2023

Conversation

jabrah
Copy link
Contributor

@jabrah jabrah commented Jan 10, 2023

Previous env config for pass-core had not been updated in a long time. There may still be some redundant vars that should be consolidated, but pass-core should now have its required properties

@jabrah jabrah requested a review from markpatton January 10, 2023 17:30
markpatton
markpatton approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@markpatton markpatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That works. Later on we need to look at merging environment variables that are doing the same thing.

@jabrah jabrah merged commit 670d2fb into main Jan 10, 2023
@jabrah jabrah deleted the update-pass-core-config branch January 10, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markpatton markpatton markpatton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jabrah @markpatton