Allow docker-compose down to "fail" as the services might have significantly changes #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icantly changes When testing against branch `294-load-data-after-up` If you run ``` docker-compose -f eclipse-pass.base.yml -f eclipse-pass.demo.yml down ``` If will fail because the compose changed _soooo much_. ``` ERROR: The Compose file is invalid because: Service ember has neither an image nor a build context specified. At least one must be provided. ``` So it should be OK for the "down" to fail and not fail the deploy.
jabrah
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing against branch
294-load-data-after-upIf you run
If will fail because the compose changed soooo much.
So it should be OK for the "down" to fail and not fail the deploy.