Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade OCFL #83

Merged
merged 3 commits into from
Mar 29, 2024
Merged

Upgrade OCFL #83

merged 3 commits into from
Mar 29, 2024

Conversation

rpoet-jh
Copy link
Contributor

@rpoet-jh rpoet-jh commented Mar 26, 2024

This PR upgrades OCFL to latest version. Notice the package change from edu.wisc.library.ocfl to io.ocfl https://mvnrepository.com/artifact/edu.wisc.library.ocfl/ocfl-java-core/2.0.1 . I could no longer find an ocfl repo under edu.wisc. The OCFL repo now associated is this https://github.com/OCFL/ocfl-java.

I also cleaned up the OCFL configuration in the FileService by refactoring most of the wiring up into the StorageConfiguration class. I also replaced S3Mock with localstack S3.

There is also localstack upgrade required in pass-docker: eclipse-pass/pass-docker#368

@rpoet-jh
Copy link
Contributor Author

Acceptance tests will fail until pass-docker PR is merged.

@rpoet-jh rpoet-jh linked an issue Mar 26, 2024 that may be closed by this pull request
Copy link
Contributor

@tsande16 tsande16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Passes Mvn verify and runs locally in pass-docker .

Copy link
Contributor

@markpatton markpatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@rpoet-jh rpoet-jh force-pushed the russ-902-ocfl-upgrade branch from 0b1f570 to f0501da Compare March 29, 2024 12:21
@rpoet-jh rpoet-jh merged commit 307943e into main Mar 29, 2024
2 checks passed
@rpoet-jh rpoet-jh deleted the russ-902-ocfl-upgrade branch August 1, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update ocfl version in pass-core
3 participants