Enable CSRF for /logout #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
To test in pass-docker, build pass-core and pass-ui (on branch for eclipse-pass/pass-ui#1294). Update pass-docker to run pass-ui:latest as usual. |
markpatton
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables CSRF requirement for the
/logoutendpoint.Note the removal of
http.saml2Logoutfrom the security configuration. This is needed so the SAML SLO logout doesn't execute when a POST is sent to/logout. I assume this is what we want because in the previous configuration, SAML SLO logout was essentially disabled because it only executes for POST requests, so it was being skipped for the GET/logoutrequests. Let me know if I missed something with this assumption.There will also be a
pass-uiPR that must be merged with this PR. eclipse-pass/pass-ui#1294