Avoid reusing packet IDs immediately #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes #442 (in an unsatisfactory way; the cause of the issue is not clear and this was supposed to aid in tracing it). There seems no downside to minimising the reuse of IDs and doing so makes it easier to trace messages in broker logs. Signed-off-by: Matt Brittan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #442 (in an unsatisfactory way; the cause of the issue is not clear and this was supposed to aid in tracing it).
Previouslly the message id was always the first integer that was unallocated (always searching up from ID 1) meaning that messageids were reused fairly quickly. This pull request changes that so that the message id will be the first free id after the one most recently issued (meaning that ids will generally be sequential and only wrap around after 65535 messages).
There seems no downside to minimising the reuse of IDs and doing so makes it easier to trace messages in broker logs. I believe that this method also mirrors how mosquitto allocates ids.