-
Notifications
You must be signed in to change notification settings - Fork 899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop #410
Open
parthipan875
wants to merge
33
commits into
master
Choose a base branch
from
develop
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Develop #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The android client is completely asynchronous, which means most methods will never throw anything, and errors must be handled on callbacks instead. Now, handling errors on asynchronous code is hard enough. Having to insert `try-catch` blocks on things that never fail only makes it worse. Therefore This patch removes `throws` declarations where they are not needed. Signed-off-by: Paulo Costa <[email protected]>
Now that unnecessary throws declarations have been removed from MqttAndroidClient.
…version Signed-off-by: James Sutton <[email protected]>
Signed-off-by: James Sutton <[email protected]>
* Alert if messageArrivedAction fails. Signed-off-by: James Sutton <[email protected]>
…ture Signed-off-by: James Sutton <[email protected]>
Various Fixes and enhancements
Remove unnecessary `throws` declarations
Signed-off-by: miketran <[email protected]>
Move ping request to AsyncTask
Signed-off-by: James Sutton <[email protected]>
Signed-off-by: James Sutton <[email protected]>
Signed-off-by: Hannes Achleitner <[email protected]>
update to most recent Gradle build tools 2.3
* support sessionPresent on connack Signed-off-by: yonishi <[email protected]> * fix wrong indentation Signed-off-by: yonishi <[email protected]>
Signed-off-by: James Sutton <[email protected]>
Signed-off-by: James Sutton <[email protected]>
Signed-off-by: Hannes Achleitner <[email protected]>
…ull clientHandle (#263) Signed-off-by: James Sutton <[email protected]>
…g for travis-ci. (#264) Signed-off-by: James Sutton <[email protected]>
* apply project codeformatter Signed-off-by: Hannes Achleitner <[email protected]> * apply code formatter to all files Signed-off-by: Hannes Achleitner <[email protected]> * code cleanup and fix Lint issues Signed-off-by: Hannes Achleitner <[email protected]>
* update to Android Studio 3.0.1 Signed-off-by: Hannes Achleitner <[email protected]> * rename simple example Signed-off-by: Hannes Achleitner <[email protected]>
Signed-off-by: Ignacio Díaz <[email protected]>
Signed-off-by: Alan Lyu <[email protected]>
signing Signed-off-by: Hannes Achleitner <[email protected]>
Signed-off-by: Hannes Achleitner <[email protected]>
Signed-off-by: Hannes Achleitner <[email protected]>
Signed-off-by: Hannes Achleitner <[email protected]>
Signed-off-by: Hannes Achleitner <[email protected]>
Signed-off-by: Hannes Achleitner <[email protected]>
…velop remove pointless .gitignore files [development]
Android Studio 3.6.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure that the following boxes are checked before submitting your Pull Request, thank you!