Include org.eclipse.pde.spies in products that include org.eclipse.pde #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include this for the committers, modeling, and rcp products where I expect such spies will be significantly useful, but not for jee. eclipse-pde/eclipse.pde#479
13 tasks
jonahgraham
approved these changes
Apr 6, 2023
There was a problem hiding this comment.
Thanks Ed. LGTM.
As this is changing package contents, it is the package maintainers who are responsible for the contents. I am pretty sure that they will be fine with it, but I am tagging them below so they know what is changing in their packages. Extra important because this is the first such change since we move to GitHub
Include this for the committers, modeling, and rcp products where I expect such spies will be significantly useful, but not for jee.
committers: @guw, @mknauer
modelling: @rschnekenbu
rcp: @mknauer
jee: @nitind, @cbridgha
I'm submitting this now, but please comment if you disagree and I can back it out before M1 build on Thursday the 13th.
jonahgraham
added a commit
to jonahgraham/packages
that referenced
this pull request
Apr 13, 2023
Follow up for eclipse-packaging#4 Part of eclipse-packaging#5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include this for the committers, modeling, and rcp products where I expect such spies will be significantly useful, but not for jee.
eclipse-pde/eclipse.pde#479