Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRIU adds @NotCheckpointSafe at ClassLoader.getClassLoadingLock() #20303

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

JasonFengJ9
Copy link
Member

CRIU adds @NotCheckpointSafe at ClassLoader.getClassLoadingLock()

This is expected to address

[err] openj9.internal.criu.JVMRestoreException: Blocking operation is not allowed in CRIU single thread mode.
[err]   at java.base/java.lang.ClassLoader.getClassLoadingLock(ClassLoader.java:1270)
[err]   at java.base/jdk.internal.loader.BuiltinClassLoader.loadClassOrNull(BuiltinClassLoader.java:837)
[err]   at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:825)
[err]   at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188)
[err]   at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:1093)
[err]   at com.ibm.ws.kernel.internal.classloader.JarFileClassLoader._loadClass(JarFileClassLoader.java:172)
[err]   at com.ibm.ws.kernel.internal.classloader.BootstrapChildFirstJarClassloader.loadClass(BootstrapChildFirstJarClassloader.java:83)
[err]   at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:1093)
[err]   at org.eclipse.osgi.internal.loader.BundleLoader.findClass0(BundleLoader.java:446)
[err]   at org.eclipse.osgi.internal.loader.BundleLoader.findClass(BundleLoader.java:416)
[err]   at org.eclipse.osgi.internal.loader.ModuleClassLoader.loadClass(ModuleClassLoader.java:168)
[err]   at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:1093)
[err]   at io.openliberty.checkpoint.internal.criu.CheckpointFailedException$Type.$values(CheckpointFailedException.java:24)
[err]   at io.openliberty.checkpoint.internal.criu.CheckpointFailedException$Type.<clinit>(CheckpointFailedException.java:24)
[err]   at io.openliberty.checkpoint.internal.CheckpointImpl.failedRestore(CheckpointImpl.java:618)
[err]   at io.openliberty.checkpoint.internal.CheckpointImpl.callHooks(CheckpointImpl.java:581)
[err]   at io.openliberty.checkpoint.internal.CheckpointImpl.restore(CheckpointImpl.java:611)
[err]   at io.openliberty.checkpoint.internal.CheckpointImpl.lambda$checkpoint$15(CheckpointImpl.java:397)
[err]   at java.base/openj9.internal.criu.InternalCRIUSupport.lambda$registerCheckpointHookHelper$2(InternalCRIUSupport.java:796)
[err]   at java.base/openj9.internal.criu.J9InternalCheckpointHookAPI$J9InternalCheckpointHook.runHook(J9InternalCheckpointHookAPI.java:143)
[err]   at java.base/openj9.internal.criu.J9InternalCheckpointHookAPI.runHooks(J9InternalCheckpointHookAPI.java:98)
[err]   at java.base/openj9.internal.criu.J9InternalCheckpointHookAPI.runPostRestoreHooksSingleThread(J9InternalCheckpointHookAPI.java:115)
[err]   at java.base/openj9.internal.criu.InternalCRIUSupport.checkpointJVMImpl(Native Method)
[err]   at java.base/openj9.internal.criu.InternalCRIUSupport.checkpointJVM(InternalCRIUSupport.java:997)
[err]   at openj9.criu/org.eclipse.openj9.criu.CRIUSupport.checkpointJVM(CRIUSupport.java:530)
[err]   at io.openliberty.checkpoint.internal.openj9.ExecuteCRIU_OpenJ9.dump(ExecuteCRIU_OpenJ9.java:55)
[err]   at io.openliberty.checkpoint.internal.CheckpointImpl.checkpoint(CheckpointImpl.java:396)

Signed-off-by: Jason Feng [email protected]

@JasonFengJ9 JasonFengJ9 added comp:vm criu Used to track CRIU snapshot related work labels Oct 4, 2024
@tajila
Copy link
Contributor

tajila commented Oct 7, 2024

jenkins test sanity zlinux jdk21

@tajila
Copy link
Contributor

tajila commented Oct 7, 2024

jenkins test sanity alinux64 jdk17

@tajila tajila merged commit 574551f into eclipse-openj9:master Oct 7, 2024
9 checks passed
@JasonFengJ9 JasonFengJ9 deleted the clnamelocknotsafe branch October 7, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:vm criu Used to track CRIU snapshot related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants