Throw IdentityException in monitorenter #19774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theresa-m
added
comp:vm
project:valhalla
hangshao0
reviewed
Jul 4, 2024
Signed-off-by: Theresa Mammarella <[email protected]>
hangshao0
reviewed
Jul 4, 2024
|
Jenkins test sanity,extended zlinuxval jdknext |
|
Jenkins test sanity,extended amac jdk21 |
...if class is value type Signed-off-by: Theresa Mammarella <[email protected]>
|
I updated the change to fix the failing test |
|
Jenkins test sanity,extended zlinuxval jdknext |
hangshao0
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue also exposed an issue with recent changes to J9_IS_CLASSFILE_VALUETYPE and J9ROMCLASS_IS_VALUE. Adding IdentityException to the test cases forced the tests to compile as 67.65535 instead of 67.0 and caused ValueTypeTest.testIsValueClassOnInterface to fail. Classes with ACC_IDENTITY are not considered value classes but they also cannot have ACC_IDENTITY flag set.
Fixes: #19464