jdk11 should create LATIN1 String constants #19337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins test sanity,sanity.openjdk amac jdk11 |
keithc-ca
requested changes
Apr 18, 2024
test/functional/Java8andUp/src/org/openj9/test/java/lang/Test_String.java
Outdated
Show resolved
Hide resolved
LATIN1 String constants were only created in jdk17 and later. The JCL for jdk11 creates LATIN1 Strings and the VM needs to match. Issue eclipse-openj9#19334 Signed-off-by: Peter Shipton <[email protected]>
... and the recent test changes shouldn't yield a different result. |
keithc-ca
approved these changes
Apr 18, 2024
This was referenced Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LATIN1 String constants were only created in jdk17 and later. The JCL for jdk11 creates LATIN1 Strings and the VM needs to match.
Issue #19334
Grinder showing the new test fails without this fix.
https://openj9-jenkins.osuosl.org/view/Test/job/Grinder/3482