Add explicit well-known classes SCC handling #18888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Attn @mpirvu. |
|
In #18301 I think I will simply modify |
cjjdespres
force-pushed
the
wellknownclasses-lookups
branch
from
6014165
to
f2db886
Compare
|
Rebased to bring in the latest merges. Shouldn't have changed anything. |
mpirvu
approved these changes
Feb 7, 2024
cjjdespres
force-pushed
the
wellknownclasses-lookups
branch
from
f2db886
to
f1ad8b2
Compare
|
Force-pushed to address comments. |
mpirvu
reviewed
Feb 7, 2024
cjjdespres
force-pushed
the
wellknownclasses-lookups
branch
from
f1ad8b2
to
54da75f
Compare
mpirvu
reviewed
Feb 7, 2024
| * (uintptr_t *classChainOffsets) value whose first element is the number of subsequent elements, | ||
| * with subsequent elements being offsets to class chains. | ||
| * | ||
| * \param[in] vmThread The buffer to fill with the SCC key |
There was a problem hiding this comment.
The definition of vmThread was copied from below and it's incorrect
| * @brief Same circumstance as offsetinSharedCacheFromClass above. | ||
| * | ||
| * @param sharedCache pointer to the TR_SharedCache object | ||
| * @param ptr well-known classes pointer whose offset in the SCC is required |
cjjdespres
force-pushed
the
wellknownclasses-lookups
branch
from
54da75f
to
dbd1b80
Compare
A new storeWellKnownClasses method in J9SharedCache is now responsible for storing a well-known classes object in the SCC. The J9::AheadOfTimeCompile::offsetInSharedCacheFromPointer has been renamed offsetInSharedCacheFromWellKnownClasses, as getting the offset of the well-known classes object stored in the SVM is currently its sole responsibility. Signed-off-by: Christian Despres <[email protected]>
cjjdespres
force-pushed
the
wellknownclasses-lookups
branch
from
dbd1b80
to
6eb3635
Compare
|
jenkins test sanity all jdk21 |
|
aix build failed due to infra: |
|
jenkins test sanity aix jdk21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new storeWellKnownClasses method in J9SharedCache is now responsible for storing a well-known classes object in the SCC.
The J9::AheadOfTimeCompile::offsetInSharedCacheFromPointer has been renamed offsetInSharedCacheFromWellKnownClasses, as getting the offset of the well-known classes object stored in the SVM is currently its sole responsibility.