Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-order StackWalker.Options to match RI #18854

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Re-order StackWalker.Options to match RI #18854

merged 1 commit into from
Jan 31, 2024

Conversation

tajila
Copy link
Contributor

@tajila tajila commented Jan 30, 2024 •
edited
Loading

Verification tests are sensitive to the ordering of the options.

@tajila
Copy link
Contributor Author

tajila commented Jan 30, 2024

@fengxue-IS Please review

Is there any J9 code that relies on the ordering?

@tajila tajila added the comp:vm label Jan 30, 2024
@fengxue-IS
Copy link
Contributor

J9 uses J9_RETAIN_CLASS_REFERENCE bit flag mapped from the options, so internally we don't rely on the ordering.

fengxue-IS
fengxue-IS approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@fengxue-IS fengxue-IS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tajila
Copy link
Contributor Author

tajila commented Jan 30, 2024

@hangshao0 please review/merge

@hangshao0
Copy link
Contributor

jenkins test sanity.functional alinux jdk21

@hangshao0
Copy link
Contributor

jenkins test extended.functional alinux jdk21

hangshao0
hangshao0 approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@hangshao0 hangshao0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hangshao0 hangshao0 merged commit b8b2cc4 into eclipse-openj9:master Jan 31, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hangshao0 hangshao0 hangshao0 approved these changes

@fengxue-IS fengxue-IS fengxue-IS approved these changes

Assignees
No one assigned
Labels
comp:vm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tajila @fengxue-IS @hangshao0