-
Notifications
You must be signed in to change notification settings - Fork 739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify SCC frontend to take class parameter #18847
Conversation
Attn @mpirvu. I know we are waiting for at least the nightly builds to pass in response to the reversion, but this is the updated PR. I've also kept |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jenkins test sanity all jdk17 |
window failed due to infra |
jenkins test sanity win jdk17 |
2 similar comments
jenkins test sanity win jdk17 |
jenkins test sanity win jdk17 |
This is a resubmission of #18821. These changes eliminate the direct use of
offsetInSharedCacheFromROMClass
during compilation in order to support #18301, as this query is difficult to fulfill using information available at the server when compiling for the JITServer AOT cache and a local SCC is not available.The previous PR caused test failures because the method definition in that PR corresponding to this one here:
was
which had the effect of not updating the value pointed to by
cacheOffset
in the JITServer AOT deserializer.