Fix JITServer bug related to ChangesCurrentThread annotation #18827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Methods that are annotated with @ChangesCurrentThread may receive special treatment from the inliner. This is a feature present only in Java21 and up. When creating a resolvedMethod mirror, the client retrieves the information related to @ChangesCurrentThread annotation and packs it into the message sent back to the server. Current code contained a bug where the information related to this annotation is not unpacked at the server. The net effect was that the inliner refused to inline some methods, reducing throughput. This commit rectifies the problem, by correctly unpacking the information related to the ChangesCurrentThread annotation. Signed-off-by: Marius Pirvu <[email protected]>
|
jenkins test sanity plinuxjit,xlinuxjit,zlinuxjit,alinux64jit jdk21 |
|
@dsouzai Could you please review/merge this simple bug fix? Thanks |
dsouzai
approved these changes
Jan 26, 2024
|
All tests have passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Methods that are annotated with @ChangesCurrentThread may receive special treatment from the inliner. This is a feature present only in Java21 and up. When creating a resolvedMethod mirror, the client retrieves the information related to @ChangesCurrentThread annotation and packs it into the message sent back to the server. Current code contained a bug where the information related to this annotation is not unpacked at the server. The net effect was that the inliner refused to inline some methods, reducing throughput. This commit rectifies the problem, by correctly unpacking the information related to the ChangesCurrentThread annotation.