[FFI/JDK22] Performance improvement via NativeMH/LinkToNative #18799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The prototype includes the changes in OpenJ9 (this PR) and in OpenJDK at ibmruntimes/openj9-openjdk-jdk#736 & ibmruntimes/openj9-openjdk-jdk22#17, in which case they should be merged altogether once approved. |
ChengJin01
force-pushed
the
ffi_perf_improvement_linktonative_vm_jdk22_v5
branch
from
1397732
to
f0b26e2
Compare
|
Reviewer: @tajila |
keithc-ca
requested changes
Jan 24, 2024
runtime/vm/OutOfLineINL_openj9_internal_foreign_abi_InternalDowncallHandler.cpp
Outdated
Show resolved
Hide resolved
jcl/src/java.base/share/classes/openj9/internal/foreign/abi/InternalDowncallHandler.java
Show resolved
Hide resolved
jcl/src/java.base/share/classes/openj9/internal/foreign/abi/InternalDowncallHandler.java
Outdated
Show resolved
Hide resolved
ChengJin01
force-pushed
the
ffi_perf_improvement_linktonative_vm_jdk22_v5
branch
2 times, most recently
from
6acc2b9
to
71e2d90
Compare
keithc-ca
reviewed
Jan 24, 2024
keithc-ca
requested changes
Jan 30, 2024
runtime/vm/OutOfLineINL_openj9_internal_foreign_abi_InternalDowncallHandler.cpp
Outdated
Show resolved
Hide resolved
runtime/vm/OutOfLineINL_openj9_internal_foreign_abi_InternalDowncallHandler.cpp
Outdated
Show resolved
Hide resolved
runtime/vm/OutOfLineINL_openj9_internal_foreign_abi_InternalUpcallHandler.cpp
Outdated
Show resolved
Hide resolved
ChengJin01
force-pushed
the
ffi_perf_improvement_linktonative_vm_jdk22_v5
branch
2 times, most recently
from
0f45817
to
f2a3b9a
Compare
keithc-ca
requested changes
Jan 31, 2024
runtime/vm/OutOfLineINL_openj9_internal_foreign_abi_InternalDowncallHandler.cpp
Outdated
Show resolved
Hide resolved
|
Could this improvement be extended to jdk21? It would be a greater benefit given jdk21 is an LTS version. |
ChengJin01
force-pushed
the
ffi_perf_improvement_linktonative_vm_jdk22_v5
branch
from
f2a3b9a
to
21f6135
Compare
There is no plan for the moment to push the optimization (still in the status of prototype/exploration) back to JDK21 (might be a little bit different in terms of the OpenJDK extension) as we have not yet confirmed whether it really works this way as expected given a bunch of work/issues with the prototype will be addressed by JIT. FYI: @tajila |
keithc-ca
requested changes
Jan 31, 2024
runtime/vm/OutOfLineINL_openj9_internal_foreign_abi_InternalDowncallHandler.cpp
Outdated
Show resolved
Hide resolved
runtime/vm/OutOfLineINL_openj9_internal_foreign_abi_InternalUpcallHandler.cpp
Outdated
Show resolved
Hide resolved
ChengJin01
force-pushed
the
ffi_perf_improvement_linktonative_vm_jdk22_v5
branch
2 times, most recently
from
dd2158d
to
1863d90
Compare
keithc-ca
reviewed
Jan 31, 2024
runtime/vm/OutOfLineINL_openj9_internal_foreign_abi_InternalDowncallHandler.cpp
Outdated
Show resolved
Hide resolved
ChengJin01
force-pushed
the
ffi_perf_improvement_linktonative_vm_jdk22_v5
branch
2 times, most recently
from
fcc0249
to
20aeec7
Compare
keithc-ca
reviewed
Jan 31, 2024
runtime/vm/OutOfLineINL_openj9_internal_foreign_abi_InternalDowncallHandler.cpp
Outdated
Show resolved
Hide resolved
ChengJin01
force-pushed
the
ffi_perf_improvement_linktonative_vm_jdk22_v5
branch
from
20aeec7
to
ec6f98c
Compare
|
Jenkins test sanity amac,zlinux,win jdknext depends ibmruntimes/openj9-openjdk-jdk#736 |
tajila
reviewed
Jan 31, 2024
jcl/src/java.base/share/classes/openj9/internal/foreign/abi/InternalDowncallHandler.java
Outdated
Show resolved
Hide resolved
tajila
reviewed
Jan 31, 2024
jcl/src/java.base/share/classes/openj9/internal/foreign/abi/InternalDowncallHandler.java
Outdated
Show resolved
Hide resolved
runtime/vm/OutOfLineINL_openj9_internal_foreign_abi_InternalDowncallHandler.cpp
Outdated
Show resolved
Hide resolved
ChengJin01
force-pushed
the
ffi_perf_improvement_linktonative_vm_jdk22_v5
branch
2 times, most recently
from
76dd44b
to
b6687f6
Compare
tajila
reviewed
Feb 1, 2024
runtime/vm/OutOfLineINL_openj9_internal_foreign_abi_InternalDowncallHandler.cpp
Outdated
Show resolved
Hide resolved
ChengJin01
force-pushed
the
ffi_perf_improvement_linktonative_vm_jdk22_v5
branch
from
b6687f6
to
9fc62be
Compare
keithc-ca
requested changes
Feb 1, 2024
jcl/src/java.base/share/classes/openj9/internal/foreign/abi/InternalDowncallHandler.java
Outdated
Show resolved
Hide resolved
jcl/src/java.base/share/classes/openj9/internal/foreign/abi/InternalDowncallHandler.java
Outdated
Show resolved
Hide resolved
runtime/vm/OutOfLineINL_openj9_internal_foreign_abi_InternalDowncallHandler.cpp
Show resolved
Hide resolved
ChengJin01
force-pushed
the
ffi_perf_improvement_linktonative_vm_jdk22_v5
branch
from
9fc62be
to
2dd0653
Compare
keithc-ca
requested changes
Feb 1, 2024
runtime/vm/OutOfLineINL_openj9_internal_foreign_abi_InternalDowncallHandler.cpp
Show resolved
Hide resolved
runtime/vm/OutOfLineINL_openj9_internal_foreign_abi_InternalDowncallHandler.cpp
Outdated
Show resolved
Hide resolved
The prototype explores the way of shrinking the performance gap in downcall by leveraging the NativeMH/LinkToNative mechanism in OpenJDK to guarantee that the LambdaForm-customized bytecode can be optimized in JIT. Note: 1) the prototype only supports primitives for the moment. 2) -Xffiproto is used to enable the prototype without the constraints on the life cycle of memory segment. Signed-off-by: ChengJin01 <[email protected]>
ChengJin01
force-pushed
the
ffi_perf_improvement_linktonative_vm_jdk22_v5
branch
from
2dd0653
to
dc2f404
Compare
keithc-ca
approved these changes
Feb 2, 2024
|
@tajila, any further comments? |
tajila
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prototype explores the way of shrinking the performance gap
in downcall by leveraging the
NativeMH/LinkToNativemechanismin OpenJDK to guarantee that the LambdaForm-customized
bytecode can be optimized in JIT.
Note:
constraints on the life cycle of memory segment.
Signed-off-by: ChengJin01 [email protected]