Ensure ROM class cache shutdown is necessary #18792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpirvu
reviewed
Jan 24, 2024
| // Time for a purge operation. | ||
| // Scan the entire table and delete old elements that are not in use | ||
| for (auto iter = _clientSessionMap.begin(); iter != _clientSessionMap.end(); ++iter) | ||
| { | ||
| TR_ASSERT(iter->second->getInUse() >= 0, "_inUse=%d must be positive\n", iter->second->getInUse()); | ||
| clientWasDeleted = true; |
There was a problem hiding this comment.
Just because we enter this loop, it doesn't mean that the clients were deleted. It only means that client sessions exist. Thus, I would change the name of the variable.
There was a problem hiding this comment.
True. I also changed the logic slightly, hopefully to be a little clearer.
Signed-off-by: Christian Despres <[email protected]>
cjjdespres
force-pushed
the
fix-romclasscache-shutdown
branch
from
ee90a75
to
27b0507
Compare
mpirvu
approved these changes
Jan 24, 2024
|
jenkins test sanity zlinuxjit jdk17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #18656, I did not check to see if any clients were actually deleted in the purge operation. If none were, then the shared ROM class cache would necessarily have been shut down already. Attempting to shut it down again would lead to a segfault. Checking if the purge operation was responsible for deleting the last clients before shutting down the shared ROM class cache avoids this issue.
Attn @mpirvu.