Disable simplifying j9Class to j.l.Class to j9Class #18743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tree Simplification recognizes an indirect load that gets a java/lang/Class from a j9Class, and then gets the j9Class from that java/lang/Class can be simplified to refer to the original j9Class pointer itself. However, that introduces an l2a operation which causes problems for Code Generation's l2aEvaluators, as they assume that l2a operations are only used for compressed references. Until the two different kinds of conversions of integers to addresses can be distinguished from one another, this transformation in Tree Simplification will be disabled.
|
@vijaysun-omr, may I ask you to review this change? |
vijaysun-omr
approved these changes
Jan 11, 2024
|
jenkins test sanity all jdk17 |
|
Pretty safe change since it only disables an optional transformation (that apparently runs rarely) until a design issue is resolved. Tests have passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tree Simplification recognizes an indirect load that gets a
java/lang/Classfrom aj9Classpointer, and then gets thej9Classpointer from thatjava/lang/Class, can be simplified to refer to the originalj9Classpointer itself. However, that introduces anl2aoperation which causes problems for Code Generation'sl2aEvaluators, as they assume thatl2aoperations are only used for compressed references. Until the two different kinds of conversions of integers to addresses can be distinguished from one another — as described in eclipse-omr/omr#6508 — this transformation in Tree Simplification will be disabled.