Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify lw5 tests after removal of aconst_init and withfield #18551

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Simplify lw5 tests after removal of aconst_init and withfield #18551

merged 1 commit into from
Dec 5, 2023

Conversation

theresa-m
Copy link
Contributor

@theresa-m theresa-m commented Dec 1, 2023 •
edited
Loading

makeRef and makeGenericValue can be combined since they both use <init> now

@theresa-m
Simplify lw5 tests after removal of aconst_init and withfield
16dce02 
makeRef and makeGenericValue can be combined since they both use <init> now

Signed-off-by: Theresa Mammarella <[email protected]>
@theresa-m theresa-m added comp:test project:valhalla Used to track Project Valhalla related work labels Dec 1, 2023
hangshao0
hangshao0 approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@hangshao0 hangshao0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hangshao0
Copy link
Contributor

The PR description is:

makeRef and makeGenericValue can be combined since they both use now.

Looks to me that <init> is missing. Could you update that ?

@theresa-m
Copy link
Contributor Author

Fixed now.

@hangshao0
Copy link
Contributor

Jenkins test sanity,extended winval jdknext

@hangshao0
Copy link
Contributor

Jenkins test sanity,extended aixval jdknext

@hangshao0 hangshao0 merged commit 9ab4edb into eclipse-openj9:master Dec 5, 2023
9 checks passed
@theresa-m theresa-m deleted the fix_lw5_tests branch December 6, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hangshao0 hangshao0 hangshao0 approved these changes

Assignees
No one assigned
Labels
comp:test project:valhalla Used to track Project Valhalla related work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theresa-m @hangshao0