Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ValueTypeArrayTests to run with lw5 compiler #18450

Merged
merged 2 commits into from
Nov 23, 2023
Merged

Update ValueTypeArrayTests to run with lw5 compiler #18450

merged 2 commits into from
Nov 23, 2023

Conversation

theresa-m
Copy link
Contributor

@theresa-m theresa-m commented Nov 14, 2023 •
edited
Loading 

- fix formatting for qtypes and lw5
- replace primitive with null-restricted
- update testStoreNullToNullRestrictedArrayElement1 and
  testStoreNullToNullRestrictedArrayElement2 to throw ArrayStoreException and
disable tests until support for nullrestricted arrays is added
- comment out ArrayStoreException for assigning null to nullrestricted array in
  expectedExceptionClass until support for nullrestricted arrays is added

Please view the lastest commit to see a diff of ValueTypeTests.java in lw5.

Related: #18157

@theresa-m theresa-m added comp:test project:valhalla Used to track Project Valhalla related work labels Nov 14, 2023
hzongaro
hzongaro reviewed Nov 15, 2023
View reviewed changes
Copy link
Member

@hzongaro hzongaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Theresa! I have a few minor comments.

test/functional/Valhalla/src_lw5/org/openj9/test/lworld/ValueTypeArrayTests.java Outdated Show resolved Hide resolved
test/functional/Valhalla/src_lw5/org/openj9/test/lworld/ValueTypeArrayTests.java Outdated Show resolved Hide resolved
test/functional/Valhalla/src_lw5/org/openj9/test/lworld/ValueTypeArrayTests.java Outdated Show resolved Hide resolved
test/functional/Valhalla/src_lw5/org/openj9/test/lworld/ValueTypeArrayTests.java Outdated Show resolved Hide resolved
hzongaro
hzongaro reviewed Nov 20, 2023
View reviewed changes
Copy link
Member

@hzongaro hzongaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some comments about some lingering lines that uses spaces for indentation.

Also, the message for commit 1d7c396c64ca598fe15ed0e6025354635e612d86 runs past 72 columns. May I ask you to add in line breaks?

test/functional/Valhalla/src_qtypes/org/openj9/test/lworld/ValueTypeArrayTests.java Outdated Show resolved Hide resolved
test/functional/Valhalla/src_qtypes/org/openj9/test/lworld/ValueTypeArrayTests.java Outdated Show resolved Hide resolved
test/functional/Valhalla/src_qtypes/org/openj9/test/lworld/ValueTypeArrayTests.java Outdated Show resolved Hide resolved
test/functional/Valhalla/src_qtypes/org/openj9/test/lworld/ValueTypeArrayTests.java Outdated Show resolved Hide resolved
@theresa-m
Copy link
Contributor Author

Thanks for the review @hzongaro the indents should be fixed now.

hzongaro
hzongaro reviewed Nov 21, 2023
View reviewed changes
Copy link
Member

@hzongaro hzongaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there are just two more lines that are indented with spaces.

Also the commit comment for 1fbc45358983ec49cda7e0602cad582e0428174f looks like it still has lines that run past 72 columns. Is your git client reformatting it?

test/functional/Valhalla/src_lw5/org/openj9/test/lworld/ValueTypeArrayTests.java Outdated Show resolved Hide resolved
test/functional/Valhalla/src_qtypes/org/openj9/test/lworld/ValueTypeArrayTests.java Outdated Show resolved Hide resolved
@theresa-m
Update ValueTypeArrayTests for lw5
83e0a42 
- fix formatting for qtypes and lw5
- replace primitive with null-restricted
- update testStoreNullToNullRestrictedArrayElement1 and
  testStoreNullToNullRestrictedArrayElement2 to throw ArrayStoreException and
disable tests until support for nullrestricted arrays is added
- comment out ArrayStoreException for assigning null to nullrestricted array in
  expectedExceptionClass until support for nullrestricted arrays is added

Signed-off-by: Theresa Mammarella <[email protected]>
@theresa-m
Copy link
Contributor Author

It looks like there are just two more lines that are indented with spaces.

Also the commit comment for 1fbc453 looks like it still has lines that run past 72 columns. Is your git client reformatting it?

I've updated the last few things.

No I've never restricted the commit body character length.

@hzongaro
Copy link
Member

I've updated the last few things.
No I've never restricted the commit body character length.

Thanks for the updates. That recommendation on commit line length comes from the commit guidelines.

hzongaro
hzongaro approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@hzongaro hzongaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@hzongaro
Copy link
Member

Jenkins test sanity xlinuxval jdknext

@hzongaro
Copy link
Member

Test run was successful. Merging.

@hzongaro hzongaro merged commit efcb713 into eclipse-openj9:master Nov 23, 2023
5 checks passed
@theresa-m theresa-m mentioned this pull request Nov 23, 2023
Open
@theresa-m theresa-m deleted the valuetypearraytests branch December 6, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hangshao0 hangshao0 hangshao0 left review comments

@hzongaro hzongaro hzongaro approved these changes

Assignees
No one assigned
Labels
comp:test project:valhalla Used to track Project Valhalla related work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@theresa-m @hzongaro @hangshao0