Update the default mode for adding to the continuation list #17802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related: eclipse-openj9#17554 Currently, the default mode is “onStarted”. This adds the continuation to the list only when the VirtualThread (or the Continuation) starts. The “onCreated” mode adds to the list as soon as the VirtualThread (or the Continuation) object is created. This mode is needed if JVMTI is used. So, the default is changed to “onCreated” until we can dynamically determine that JVMTI won’t be used. With “onStarted” as default, the following failures started to occur last week: - eclipse-openj9#17784 - eclipse-openj9#17791 (intermittent) - eclipse-openj9#17782 (intermittent) Signed-off-by: Babneet Singh <[email protected]>
|
@amicic Requesting to review. |
amicic
approved these changes
Jul 17, 2023
|
jenkins compile win jdk20 |
1 similar comment
|
jenkins compile win jdk20 |
@amicic The compile has succeeded but there are infra issues at the end which cause a timeout. |
|
ok, merging, as per previous comment this compiles |
This was referenced Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #17554
Currently, the default mode is “onStarted”. This adds the continuation
to the list only when the VirtualThread (or the Continuation) starts.
The “onCreated” mode adds to the list as soon as the VirtualThread
(or the Continuation) object is created. This mode is needed if JVMTI
is used. So, the default is changed to “onCreated” until we can
dynamically determine that JVMTI won’t be used.
With “onStarted” as default, the following failures started to occur
last week: