Preserve vector registers across helper calls on P #12350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optionally preserve the vector registers in the assembly helpers on Power. This is controlled by the J9_EXTENDED_RUNTIME_USE_VECTOR_REGISTERS bit in the J9JavaVM extendedRuntimeFlags field. Fixes: eclipse-openj9#11752 [ci skip] Signed-off-by: Graham Chapman <[email protected]>
- Use different temp registers to avoid corrupting the arguments to jitSoftwareReadBarrier - Move jitStackOverflow into the optimized category for improved performance [ci skip] Signed-off-by: Graham Chapman <[email protected]>
Code was incorrectly looking in javaVM->runtimeFlags instead of extendedRuntimeFlags. [ci skip] Signed-off-by: Graham Chapman <[email protected]>
|
This is the same change as before, with a new commit to fix the crash in interpreter startup. The only review needed is for c1c0213 |
|
I've removed the "fixes:" from the description as I need to add 32-bit support before the work is complete. I'll do this in a separate PR. |
pshipton
approved these changes
Apr 5, 2021
|
This was tested internally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optionally preserve the vector registers in the assembly helpers on Power. This is controlled by the J9_EXTENDED_RUNTIME_USE_VECTOR_REGISTERS bit in the J9JavaVM extendedRuntimeFlags field.
[ci skip]
Signed-off-by: Graham Chapman [email protected]