Compile JitDump from crashed PC for application thread crashes #12311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The stack walker may not be able to walk the stack if the crash did not happen on a transition frame. In such cases the stack walker will resume walking the stack on the last known valid point, which will be a transition frame further up the stack (ex. INT -> JIT transition frame). This will result in the stack walker potentially skipping some JIT methods on the backtrace. This is not desirable. Chances are high that the crash happen because of a miscompilation in the first JIT compiled method on the stack, so it is imperative that we recompile the method we actually crashed in. Signed-off-by: Filip Jeremic <[email protected]>
|
Suggesting @dsouzai for review. @VermaSh FYI this fixes the reason why a JitDump couldn't be generated for the unit test you described in #11531 (comment). After this fix I have verified the JitDump does get generated. |
23 tasks
dsouzai
approved these changes
Mar 29, 2021
|
jenkins test sanity zlinux jdk11 |
|
This one should be ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stack walker may not be able to walk the stack if the crash did
not happen on a transition frame. In such cases the stack walker
will resume walking the stack on the last known valid point, which
will be a transition frame further up the stack (ex. INT -> JIT
transition frame). This will result in the stack walker potentially
skipping some JIT methods on the backtrace. This is not desirable.
Chances are high that the crash happen because of a miscompilation
in the first JIT compiled method on the stack, so it is imperative
that we recompile the method we actually crashed in.
Signed-off-by: Filip Jeremic [email protected]