Simplify ArrayStoreCHK evaluator #11530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the evaluator for ArrayStoreCHK included duplicate code for performing write barriers. While this did provide one small optimization benefit (it avoided performing two null checks for a certain kind of write barrier), it required that a lot of very complex code for performing write barriers be duplicated and would make changes to this code needlessly difficult due to the way that support is currently written. While it should be possible to reintroduce this optimization in the future, in the interests of simplicity while the write barrier code is undergoing some modifications, this code has been deduplicated by having the ArrayStoreCHK evaluator defer to the awrtbari evaluator to perform the write barrier. Signed-off-by: Ben Thomas <[email protected]>
|
Jenkins test sanity plinux,aix jdk8,jdk11 |
gita-omr
approved these changes
Dec 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the evaluator for ArrayStoreCHK included duplicate code for
performing write barriers. While this did provide one small optimization
benefit (it avoided performing two null checks for a certain kind of
write barrier), it required that a lot of very complex code for
performing write barriers be duplicated and would make changes to this
code needlessly difficult due to the way that support is currently
written.
While it should be possible to reintroduce this optimization in the
future, in the interests of simplicity while the write barrier code is
undergoing some modifications, this code has been deduplicated by having
the ArrayStoreCHK evaluator defer to the awrtbari evaluator to perform
the write barrier.
Signed-off-by: Ben Thomas [email protected]