Ensure AOT Compilation in JIT Dump #10852
Conversation
Ensure that if there is a crash during an AOT compilation, the JIT Dump performs an AOT compilation as well. Signed-off-by: Irwin D'Souza <[email protected]>
|
@mpirvu could you please take a look? |
| jittedMethodsOnStack[i]._optLevel, | ||
| false, | ||
| jittedMethodsOnStack[i]._oldStartPC, | ||
| isAOTBody, |
There was a problem hiding this comment.
I should note, I don't think this will actually result in an AOT compilation; this is because the method is already in the SCC, so the control code will probably just try to do an AOT load. However, if the AOT compilation was also done in the current JVM, it would be nice to be able to log that compilation as well, though this would require keeping track of the methods that were AOT compiled by the current JVM.
There was a problem hiding this comment.
Will you add more code to bypass those AOT loads? Otherwise the current change does not achieve its intended effect.
There was a problem hiding this comment.
I figured I would leave that for a future PR, since trying to do that in this PR might result in quite a big PR.
|
jenkins test sanity all jdk11 |
Ensure that if there is a crash during an AOT compilation, the JIT Dump
performs an AOT compilation as well.
Signed-off-by: Irwin D'Souza [email protected]