Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jep425Tests_testVirtualThread verifyJVMTIMacros - the VirtualThread states in jdk22 are different #18693

Closed
pshipton opened this issue Jan 5, 2024 · 8 comments

Comments

@pshipton
Copy link
Member

pshipton commented Jan 5, 2024

https://openj9-jenkins.osuosl.org/job/Test_openjdk22_j9_sanity.functional_aarch64_mac_Personal_testList_0/1
https://openj9-jenkins.osuosl.org/job/Test_openjdk22_j9_sanity.functional_aarch64_mac_Personal_testList_1/1
Jep425Tests_testVirtualThread

FAILED: test_verifyJVMTIMacros
java.lang.AssertionError: Unexpected exception occured : RUNNABLE
	at org.testng.Assert.fail(Assert.java:85)
	at org.openj9.test.jep425.VirtualThreadTests.test_verifyJVMTIMacros(VirtualThreadTests.java:350)

The VirtualThread states in jdk22 are different from jdk21 and the test.

    private static final int NEW      = 0;
    private static final int STARTED  = 1;
    private static final int RUNNING  = 2;     // runnable-mounted

    // untimed and timed parking
    private static final int PARKING       = 3;
    private static final int PARKED        = 4;     // unmounted
    private static final int PINNED        = 5;     // mounted
    private static final int TIMED_PARKING = 6;
    private static final int TIMED_PARKED  = 7;     // unmounted
    private static final int TIMED_PINNED  = 8;     // mounted
    private static final int UNPARKED      = 9;     // unmounted but runnable
@pshipton
Copy link
Member Author

pshipton commented Jan 5, 2024

@babsingh

@pshipton pshipton changed the title Jep425Tests_testVirtualThread - the VirtualThread states in jdk22 are different Jep425Tests_testVirtualThread verifyJVMTIMacros - the VirtualThread states in jdk22 are different Jan 5, 2024
@babsingh
Copy link
Contributor

babsingh commented Jan 6, 2024

This issue will be resolved by

This is related to https://bugs.openjdk.org/browse/JDK-8321270, and JDK21 is also affected by this issue. So, the new virtual thread states will eventually be ported to JDK21. The above extension repo PR backoprts the fix to JDK21 so that we don't have to add ifdefs in the OpenJ9 PR.

@keithc-ca
Copy link
Contributor

The pull requests mentioned in #18693 (comment) have been merged. Is it time to close this?

@pshipton
Copy link
Member Author

@pshipton
Copy link
Member Author

That's not going to work, there is no jdk22 build created since the fix was merged. I've started a build and will restart the grinder.

@babsingh
Copy link
Contributor

babsingh commented Jan 29, 2024

Closing the issue. Tested locally with the latest OpenJ9 JDK22, and the test passes.

@pshipton
Copy link
Member Author

https://openj9-jenkins.osuosl.org/view/Test/job/Grinder/3196/ also passed.

@pshipton
Copy link
Member Author

I've also added a nightly build of jdk22 for all platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants